diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2018-10-05 15:51:44 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-11-04 14:51:48 +0100 |
| commit | 28d6d22365647756815e46b5bb6cede250371a2b (patch) | |
| tree | 0da38138424205a332fb196ebdc520621d007003 /mm | |
| parent | 203711a8820bf6f0e6d3e9c61fbd900730b6f0e5 (diff) | |
| download | linux-stable-28d6d22365647756815e46b5bb6cede250371a2b.tar.gz linux-stable-28d6d22365647756815e46b5bb6cede250371a2b.tar.bz2 linux-stable-28d6d22365647756815e46b5bb6cede250371a2b.zip | |
mm/gup_benchmark: fix unsigned comparison to zero in __gup_benchmark_ioctl
[ Upstream commit 51896864579d5a3349740847083f4db5c6487164 ]
get_user_pages_fast() will return negative value if no pages were pinned,
then be converted to a unsigned, which is compared to zero, giving the
wrong result.
Link: http://lkml.kernel.org/r/20180921095015.26088-1-yuehaibing@huawei.com
Fixes: 09e35a4a1ca8 ("mm/gup_benchmark: handle gup failures")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/gup_benchmark.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/mm/gup_benchmark.c b/mm/gup_benchmark.c index 6a473709e9b6..7405c9d89d65 100644 --- a/mm/gup_benchmark.c +++ b/mm/gup_benchmark.c @@ -19,7 +19,8 @@ static int __gup_benchmark_ioctl(unsigned int cmd, struct gup_benchmark *gup) { ktime_t start_time, end_time; - unsigned long i, nr, nr_pages, addr, next; + unsigned long i, nr_pages, addr, next; + int nr; struct page **pages; nr_pages = gup->size / PAGE_SIZE; |