diff options
author | Chengfeng Ye <dg573847474@gmail.com> | 2023-12-07 12:34:53 +0000 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-12-20 15:32:32 +0100 |
commit | 9e8551648a456e5a14a9353c9c45d224a8f28e90 (patch) | |
tree | de2de705b1b5bf89354b9ac32bfa6e3472ee3600 /net/atm/ioctl.c | |
parent | a918d0cd5bb647233a4f70815cfe17af97285edb (diff) | |
download | linux-stable-9e8551648a456e5a14a9353c9c45d224a8f28e90.tar.gz linux-stable-9e8551648a456e5a14a9353c9c45d224a8f28e90.tar.bz2 linux-stable-9e8551648a456e5a14a9353c9c45d224a8f28e90.zip |
atm: solos-pci: Fix potential deadlock on &tx_queue_lock
[ Upstream commit 15319a4e8ee4b098118591c6ccbd17237f841613 ]
As &card->tx_queue_lock is acquired under softirq context along the
following call chain from solos_bh(), other acquisition of the same
lock inside process context should disable at least bh to avoid double
lock.
<deadlock #2>
pclose()
--> spin_lock(&card->tx_queue_lock)
<interrupt>
--> solos_bh()
--> fpga_tx()
--> spin_lock(&card->tx_queue_lock)
This flaw was found by an experimental static analysis tool I am
developing for irq-related deadlock.
To prevent the potential deadlock, the patch uses spin_lock_bh()
on &card->tx_queue_lock under process context code consistently to
prevent the possible deadlock scenario.
Fixes: 213e85d38912 ("solos-pci: clean up pclose() function")
Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net/atm/ioctl.c')
0 files changed, 0 insertions, 0 deletions