diff options
| author | Peter Oskolkov <posk@google.com> | 2024-01-12 16:53:05 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-01-15 18:23:44 +0100 |
| commit | 47468fae2704151503214f4d4327c164118247fd (patch) | |
| tree | 0af90595220cb6897e67e7ad06086f3f86a39365 /net/core | |
| parent | 610003d742341dddca03a83beb7c61f1f079b8c5 (diff) | |
| download | linux-stable-47468fae2704151503214f4d4327c164118247fd.tar.gz linux-stable-47468fae2704151503214f4d4327c164118247fd.tar.bz2 linux-stable-47468fae2704151503214f4d4327c164118247fd.zip | |
net: add a route cache full diagnostic message
commit 22c2ad616b74f3de2256b242572ab449d031d941 upstream.
In some testing scenarios, dst/route cache can fill up so quickly
that even an explicit GC call occasionally fails to clean it up. This leads
to sporadically failing calls to dst_alloc and "network unreachable" errors
to the user, which is confusing.
This patch adds a diagnostic message to make the cause of the failure
easier to determine.
Signed-off-by: Peter Oskolkov <posk@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Suraj Jitindar Singh <surajjs@amazon.com>
Cc: <stable@vger.kernel.org> # 4.19.x
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/dst.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/net/core/dst.c b/net/core/dst.c index 81ccf20e2826..a263309df115 100644 --- a/net/core/dst.c +++ b/net/core/dst.c @@ -98,8 +98,12 @@ void *dst_alloc(struct dst_ops *ops, struct net_device *dev, struct dst_entry *dst; if (ops->gc && dst_entries_get_fast(ops) > ops->gc_thresh) { - if (ops->gc(ops)) + if (ops->gc(ops)) { + printk_ratelimited(KERN_NOTICE "Route cache is full: " + "consider increasing sysctl " + "net.ipv[4|6].route.max_size.\n"); return NULL; + } } dst = kmem_cache_alloc(ops->kmem_cachep, GFP_ATOMIC); |