summaryrefslogtreecommitdiffstats
path: root/net/ipv6
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2024-02-09 15:30:56 +0000
committerSasha Levin <sashal@kernel.org>2024-03-26 18:19:28 -0400
commit26d4bac55750d535f1f0b8790dc26daf6089e373 (patch)
tree96d6eb409ce4ccbabb28c2503d8e9a76291586c4 /net/ipv6
parent5ebcdbcb9e2c1588f3efc8e9889d568456a200c2 (diff)
downloadlinux-stable-26d4bac55750d535f1f0b8790dc26daf6089e373.tar.gz
linux-stable-26d4bac55750d535f1f0b8790dc26daf6089e373.tar.bz2
linux-stable-26d4bac55750d535f1f0b8790dc26daf6089e373.zip
ipv6: mcast: remove one synchronize_net() barrier in ipv6_mc_down()
[ Upstream commit 17ef8efc00b34918b966388b2af0993811895a8c ] As discussed in the past (commit 2d3916f31891 ("ipv6: fix skb drops in igmp6_event_query() and igmp6_event_report()")) I think the synchronize_net() call in ipv6_mc_down() is not needed. Under load, synchronize_net() can last between 200 usec and 5 ms. KASAN seems to agree as well. Fixes: f185de28d9ae ("mld: add new workqueues for process mld events") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Taehee Yoo <ap420073@gmail.com> Cc: Cong Wang <xiyou.wangcong@gmail.com> Cc: David Ahern <dsahern@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net/ipv6')
-rw-r--r--net/ipv6/mcast.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index f948cf7bfc44..fae30bdca907 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -2720,7 +2720,6 @@ void ipv6_mc_down(struct inet6_dev *idev)
/* Should stop work after group drop. or we will
* start work again in mld_ifc_event()
*/
- synchronize_net();
mld_query_stop_work(idev);
mld_report_stop_work(idev);