diff options
author | Gal Pressman <pressmangal@gmail.com> | 2018-07-26 23:40:33 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-07-26 21:30:13 -0700 |
commit | 101f0cd4f2216d32f1b8a75a2154cf3997484ee2 (patch) | |
tree | fe89dd15ae230b06bde2e3481f83970d58be8dc1 /net/l3mdev | |
parent | 9e630bcb7701f94dbd729fe57d37c089c763ad9f (diff) | |
download | linux-stable-101f0cd4f2216d32f1b8a75a2154cf3997484ee2.tar.gz linux-stable-101f0cd4f2216d32f1b8a75a2154cf3997484ee2.tar.bz2 linux-stable-101f0cd4f2216d32f1b8a75a2154cf3997484ee2.zip |
net: ena: Fix use of uninitialized DMA address bits field
UBSAN triggers the following undefined behaviour warnings:
[...]
[ 13.236124] UBSAN: Undefined behaviour in drivers/net/ethernet/amazon/ena/ena_eth_com.c:468:22
[ 13.240043] shift exponent 64 is too large for 64-bit type 'long long unsigned int'
[...]
[ 13.744769] UBSAN: Undefined behaviour in drivers/net/ethernet/amazon/ena/ena_eth_com.c:373:4
[ 13.748694] shift exponent 64 is too large for 64-bit type 'long long unsigned int'
[...]
When splitting the address to high and low, GENMASK_ULL is used to generate
a bitmask with dma_addr_bits field from io_sq (in ena_com_prepare_tx and
ena_com_add_single_rx_desc).
The problem is that dma_addr_bits is not initialized with a proper value
(besides being cleared in ena_com_create_io_queue).
Assign dma_addr_bits the correct value that is stored in ena_dev when
initializing the SQ.
Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Gal Pressman <pressmangal@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/l3mdev')
0 files changed, 0 insertions, 0 deletions