diff options
author | Hans de Goede <hdegoede@redhat.com> | 2021-02-01 16:29:56 +0100 |
---|---|---|
committer | Johannes Berg <johannes.berg@intel.com> | 2021-02-01 19:26:10 +0100 |
commit | 50af06d43eab6b09afc37aa7c8bbf69b14a3b2f7 (patch) | |
tree | 0125a2144b267ce1e024dbd33d5893302742376d /net/lapb/lapb_out.c | |
parent | 18fe0fae61252b5ae6e26553e2676b5fac555951 (diff) | |
download | linux-stable-50af06d43eab6b09afc37aa7c8bbf69b14a3b2f7.tar.gz linux-stable-50af06d43eab6b09afc37aa7c8bbf69b14a3b2f7.tar.bz2 linux-stable-50af06d43eab6b09afc37aa7c8bbf69b14a3b2f7.zip |
staging: rtl8723bs: Move wiphy setup to after reading the regulatory settings from the chip
Commit 81f153faacd0 ("staging: rtl8723bs: fix wireless regulatory API
misuse") moved the wiphy_apply_custom_regulatory() call to earlier in the
driver's init-sequence, so that it gets called before wiphy_register().
But at this point in time the eFuses which code the regulatory-settings
for the chip have not been read by the driver yet, causing
_rtw_reg_apply_flags() to set the IEEE80211_CHAN_DISABLED flag on *all*
channels.
On the device where I initially tested the fix, a Jumper EZpad 7 tablet,
this does not cause any problems because shortly after init the
rtw_reg_notifier() gets called fixing things up. I guess this happens
into response to receiving a (broadcast) packet with regulatory info
from the access-point ?
But on another device with a RTL8723BS wifi chip, an Acer Switch 10E
(SW3-016), the rtw_reg_notifier() never gets called. I assume that some
fuse has been set on this device to ignore regulatory info received from
access-points.
This means that on the Acer the driver is stuck in a state with all
channels disabled, leading to non working Wifi.
We cannot move the wiphy_apply_custom_regulatory() call back, because
that call must be made before the wiphy_register() call.
Instead move the entire rtw_wdev_alloc() call to after the Efuses have
been read, fixing all channels being disabled in the initial channel-map.
Fixes: 81f153faacd0 ("staging: rtl8723bs: fix wireless regulatory API misuse")
Cc: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20210201152956.370186-2-hdegoede@redhat.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/lapb/lapb_out.c')
0 files changed, 0 insertions, 0 deletions