diff options
author | Vegard Nossum <vegard.nossum@oracle.com> | 2016-07-14 23:02:47 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-08-16 09:33:20 +0200 |
commit | ce1afec0b14dc1cfb7b9777bec8833ffa216a6a8 (patch) | |
tree | c73eaef65085dd671fe8b52089e7aac7392eeaf4 /net/mac80211/offchannel.c | |
parent | d123a55f85f5116d686dac80c768ee5c34ec8e06 (diff) | |
download | linux-stable-ce1afec0b14dc1cfb7b9777bec8833ffa216a6a8.tar.gz linux-stable-ce1afec0b14dc1cfb7b9777bec8833ffa216a6a8.tar.bz2 linux-stable-ce1afec0b14dc1cfb7b9777bec8833ffa216a6a8.zip |
ext4: fix reference counting bug on block allocation error
commit 554a5ccc4e4a20c5f3ec859de0842db4b4b9c77e upstream.
If we hit this error when mounted with errors=continue or
errors=remount-ro:
EXT4-fs error (device loop0): ext4_mb_mark_diskspace_used:2940: comm ext4.exe: Allocating blocks 5090-6081 which overlap fs metadata
then ext4_mb_new_blocks() will call ext4_mb_release_context() and try to
continue. However, ext4_mb_release_context() is the wrong thing to call
here since we are still actually using the allocation context.
Instead, just error out. We could retry the allocation, but there is a
possibility of getting stuck in an infinite loop instead, so this seems
safer.
[ Fixed up so we don't return EAGAIN to userspace. --tytso ]
Fixes: 8556e8f3b6 ("ext4: Don't allow new groups to be added during block allocation")
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/mac80211/offchannel.c')
0 files changed, 0 insertions, 0 deletions