diff options
| author | Davide Caratti <dcaratti@redhat.com> | 2020-12-03 10:46:06 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-12-08 10:40:27 +0100 |
| commit | 1086f789060ab968314b93ddbee91547f276b5d9 (patch) | |
| tree | 52d6dd64dfe342b4e1d378eca120fd60e00423eb /net/openvswitch | |
| parent | ba203b92a829c8aaf8763c76034e21e687b1b9bf (diff) | |
| download | linux-stable-1086f789060ab968314b93ddbee91547f276b5d9.tar.gz linux-stable-1086f789060ab968314b93ddbee91547f276b5d9.tar.bz2 linux-stable-1086f789060ab968314b93ddbee91547f276b5d9.zip | |
net: openvswitch: ensure LSE is pullable before reading it
[ Upstream commit 43c13605bad44b8abbc9776d6e63f62ccb7a47d6 ]
when openvswitch is configured to mangle the LSE, the current value is
read from the packet dereferencing 4 bytes at mpls_hdr(): ensure that
the label is contained in the skb "linear" area.
Found by code inspection.
Fixes: d27cf5c59a12 ("net: core: add MPLS update core helper and use in OvS")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Link: https://lore.kernel.org/r/aa099f245d93218b84b5c056b67b6058ccf81a66.1606987185.git.dcaratti@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/openvswitch')
| -rw-r--r-- | net/openvswitch/actions.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index 3d96dab10449..425e146523cc 100644 --- a/net/openvswitch/actions.c +++ b/net/openvswitch/actions.c @@ -196,6 +196,9 @@ static int set_mpls(struct sk_buff *skb, struct sw_flow_key *flow_key, __be32 lse; int err; + if (!pskb_may_pull(skb, skb_network_offset(skb) + MPLS_HLEN)) + return -ENOMEM; + stack = mpls_hdr(skb); lse = OVS_MASKED(stack->label_stack_entry, *mpls_lse, *mask); err = skb_mpls_update_lse(skb, lse); |