summaryrefslogtreecommitdiffstats
path: root/net/rds
diff options
context:
space:
mode:
authorMohamed Ghannam <simo.ghannam@gmail.com>2018-01-02 19:44:34 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-01-17 09:45:21 +0100
commit5d127d15ad2f9f33af788f1edf720ba29317f55b (patch)
tree778f2e18d3f43a685ded4ea6af19f685d423a929 /net/rds
parent5837f963300b63264dd1baf32e96063e807ca28c (diff)
downloadlinux-stable-5d127d15ad2f9f33af788f1edf720ba29317f55b.tar.gz
linux-stable-5d127d15ad2f9f33af788f1edf720ba29317f55b.tar.bz2
linux-stable-5d127d15ad2f9f33af788f1edf720ba29317f55b.zip
RDS: Heap OOB write in rds_message_alloc_sgs()
[ Upstream commit c095508770aebf1b9218e77026e48345d719b17c ] When args->nr_local is 0, nr_pages gets also 0 due some size calculation via rds_rm_size(), which is later used to allocate pages for DMA, this bug produces a heap Out-Of-Bound write access to a specific memory region. Signed-off-by: Mohamed Ghannam <simo.ghannam@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/rds')
-rw-r--r--net/rds/rdma.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index bc2f1e0977d6..94729d9da437 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -525,6 +525,9 @@ int rds_rdma_extra_size(struct rds_rdma_args *args)
local_vec = (struct rds_iovec __user *)(unsigned long) args->local_vec_addr;
+ if (args->nr_local == 0)
+ return -EINVAL;
+
/* figure out the number of pages in the vector */
for (i = 0; i < args->nr_local; i++) {
if (copy_from_user(&vec, &local_vec[i],