diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-02-07 19:02:52 -0600 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-02-08 22:57:27 -0800 |
commit | 8fe5756c73822b2891b9316eae0195f1da2a1bb2 (patch) | |
tree | 6ce19e01f8e59d6a15eaf695048bda5c6189570e /net/sched/act_pedit.c | |
parent | 4154b567b6d15a03cc9ac6c263c261da99b1ba32 (diff) | |
download | linux-stable-8fe5756c73822b2891b9316eae0195f1da2a1bb2.tar.gz linux-stable-8fe5756c73822b2891b9316eae0195f1da2a1bb2.tar.bz2 linux-stable-8fe5756c73822b2891b9316eae0195f1da2a1bb2.zip |
net/sched: use struct_size() helper
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:
struct foo {
int stuff;
struct boo entry[];
};
size = sizeof(struct foo) + count * sizeof(struct boo);
instance = alloc(size, GFP_KERNEL)
Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:
size = struct_size(instance, entry, count);
instance = alloc(size, GFP_KERNEL)
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_pedit.c')
-rw-r--r-- | net/sched/act_pedit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c index 2b372a06b432..3663d3b615a4 100644 --- a/net/sched/act_pedit.c +++ b/net/sched/act_pedit.c @@ -406,7 +406,7 @@ static int tcf_pedit_dump(struct sk_buff *skb, struct tc_action *a, struct tcf_t t; int s; - s = sizeof(*opt) + p->tcfp_nkeys * sizeof(struct tc_pedit_key); + s = struct_size(opt, keys, p->tcfp_nkeys); /* netlink spinlocks held above us - must use ATOMIC */ opt = kzalloc(s, GFP_ATOMIC); |