diff options
| author | Patrick McHardy <kaber@trash.net> | 2008-11-19 08:03:09 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-11-20 04:14:28 -0800 |
| commit | 47a1a1d4be2910b13a8e90f75c17e253c39531ff (patch) | |
| tree | c900f283bd96f0b26236152ada24f9a113f65e2b /net/sched/cls_route.c | |
| parent | b94c8afcba3ae6584653b98e315446ea83be6ea5 (diff) | |
| download | linux-stable-47a1a1d4be2910b13a8e90f75c17e253c39531ff.tar.gz linux-stable-47a1a1d4be2910b13a8e90f75c17e253c39531ff.tar.bz2 linux-stable-47a1a1d4be2910b13a8e90f75c17e253c39531ff.zip | |
pkt_sched: remove unnecessary xchg() in packet classifiers
The use of xchg() hasn't been necessary since 2.2.something when proper
locking was added to packet schedulers. In the case of classifiers they
mostly weren't even necessary before that since they're mainly used
to assign a NULL pointer to the filter root in the ->destroy path;
the root is destroyed immediately after that.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_route.c')
| -rw-r--r-- | net/sched/cls_route.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/cls_route.c b/net/sched/cls_route.c index e3d8455eebc2..bdf1f4172eef 100644 --- a/net/sched/cls_route.c +++ b/net/sched/cls_route.c @@ -260,7 +260,7 @@ route4_delete_filter(struct tcf_proto *tp, struct route4_filter *f) static void route4_destroy(struct tcf_proto *tp) { - struct route4_head *head = xchg(&tp->root, NULL); + struct route4_head *head = tp->root; int h1, h2; if (head == NULL) |