summaryrefslogtreecommitdiffstats
path: root/net/smc
diff options
context:
space:
mode:
authorBiju Das <biju.das.jz@bp.renesas.com>2022-10-25 16:56:55 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-11-03 23:52:33 +0900
commit98de6b78047ea7acea512c9706dba4c37a773c95 (patch)
treea921503a6244ed899046d85e4ad23a95276503e4 /net/smc
parentae3c8503a44b965fcb74ce4017fa0ea26f452d70 (diff)
downloadlinux-stable-98de6b78047ea7acea512c9706dba4c37a773c95.tar.gz
linux-stable-98de6b78047ea7acea512c9706dba4c37a773c95.tar.bz2
linux-stable-98de6b78047ea7acea512c9706dba4c37a773c95.zip
can: rcar_canfd: rcar_canfd_handle_global_receive(): fix IRQ storm on global FIFO receive
commit 702de2c21eed04c67cefaaedc248ef16e5f6b293 upstream. We are seeing an IRQ storm on the global receive IRQ line under heavy CAN bus load conditions with both CAN channels enabled. Conditions: The global receive IRQ line is shared between can0 and can1, either of the channels can trigger interrupt while the other channel's IRQ line is disabled (RFIE). When global a receive IRQ interrupt occurs, we mask the interrupt in the IRQ handler. Clearing and unmasking of the interrupt is happening in rx_poll(). There is a race condition where rx_poll() unmasks the interrupt, but the next IRQ handler does not mask the IRQ due to NAPIF_STATE_MISSED flag (e.g.: can0 RX FIFO interrupt is disabled and can1 is triggering RX interrupt, the delay in rx_poll() processing results in setting NAPIF_STATE_MISSED flag) leading to an IRQ storm. This patch fixes the issue by checking IRQ active and enabled before handling the IRQ on a particular channel. Fixes: dd3bd23eb438 ("can: rcar_canfd: Add Renesas R-Car CAN FD driver") Suggested-by: Marc Kleine-Budde <mkl@pengutronix.de> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Link: https://lore.kernel.org/all/20221025155657.1426948-2-biju.das.jz@bp.renesas.com Cc: stable@vger.kernel.org [mkl: adjust commit message] Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> [biju: removed gpriv from RCANFD_RFCC_RFIE macro] Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/smc')
0 files changed, 0 insertions, 0 deletions