summaryrefslogtreecommitdiffstats
path: root/net/tipc
diff options
context:
space:
mode:
authorStefano Garzarella <sgarzare@redhat.com>2021-02-09 09:52:19 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-02-23 15:00:58 +0100
commitb3c91763e2e40cad3cf7753e0a1c8045ec31985b (patch)
tree47e36eb566a5c849faf4369dfdb1951332af6f2c /net/tipc
parentafb1f8a1ea17cd156ee8e17ad76fb5fc3e1d332b (diff)
downloadlinux-stable-b3c91763e2e40cad3cf7753e0a1c8045ec31985b.tar.gz
linux-stable-b3c91763e2e40cad3cf7753e0a1c8045ec31985b.tar.bz2
linux-stable-b3c91763e2e40cad3cf7753e0a1c8045ec31985b.zip
vsock: fix locking in vsock_shutdown()
commit 1c5fae9c9a092574398a17facc31c533791ef232 upstream. In vsock_shutdown() we touched some socket fields without holding the socket lock, such as 'state' and 'sk_flags'. Also, after the introduction of multi-transport, we are accessing 'vsk->transport' in vsock_send_shutdown() without holding the lock and this call can be made while the connection is in progress, so the transport can change in the meantime. To avoid issues, we hold the socket lock when we enter in vsock_shutdown() and release it when we leave. Among the transports that implement the 'shutdown' callback, only hyperv_transport acquired the lock. Since the caller now holds it, we no longer take it. Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/tipc')
0 files changed, 0 insertions, 0 deletions