diff options
author | Antony Antony <antony.antony@secunet.com> | 2022-02-01 07:51:57 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-03-08 19:04:07 +0100 |
commit | 33c4a43021acfb91e289b2d92e2db0f4a8fcf41e (patch) | |
tree | 26286a33115e385e2186737ea60cfed34c68dbb9 /net/xfrm | |
parent | bdd8fc1b826e6f23963f5bef3f7431c6188ec954 (diff) | |
download | linux-stable-33c4a43021acfb91e289b2d92e2db0f4a8fcf41e.tar.gz linux-stable-33c4a43021acfb91e289b2d92e2db0f4a8fcf41e.tar.bz2 linux-stable-33c4a43021acfb91e289b2d92e2db0f4a8fcf41e.zip |
xfrm: fix the if_id check in changelink
commit 6d0d95a1c2b07270870e7be16575c513c29af3f1 upstream.
if_id will be always 0, because it was not yet initialized.
Fixes: 8dce43919566 ("xfrm: interface with if_id 0 should return error")
Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Antony Antony <antony.antony@secunet.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/xfrm')
-rw-r--r-- | net/xfrm/xfrm_interface.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c index 054897358d90..1ae8caca28a0 100644 --- a/net/xfrm/xfrm_interface.c +++ b/net/xfrm/xfrm_interface.c @@ -698,12 +698,12 @@ static int xfrmi_changelink(struct net_device *dev, struct nlattr *tb[], struct net *net = xi->net; struct xfrm_if_parms p = {}; + xfrmi_netlink_parms(data, &p); if (!p.if_id) { NL_SET_ERR_MSG(extack, "if_id must be non zero"); return -EINVAL; } - xfrmi_netlink_parms(data, &p); xi = xfrmi_locate(net, &p); if (!xi) { xi = netdev_priv(dev); |