summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2015-11-03 19:20:34 +0100
committerAntonio Quartulli <a@unstable.cc>2016-01-09 20:56:00 +0800
commitf75a33aeed0776f52da05276c2ef98e16d680a6b (patch)
treec4123546f4f42975ca6ce3b6bee324117458a3fc /net
parent8bbb7cb2324d6a5fb7ccdc4ab0099dc18b91b690 (diff)
downloadlinux-stable-f75a33aeed0776f52da05276c2ef98e16d680a6b.tar.gz
linux-stable-f75a33aeed0776f52da05276c2ef98e16d680a6b.tar.bz2
linux-stable-f75a33aeed0776f52da05276c2ef98e16d680a6b.zip
batman-adv: Delete an unnecessary check before the function call "batadv_softif_vlan_free_ref"
The batadv_softif_vlan_free_ref() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch> Signed-off-by: Antonio Quartulli <a@unstable.cc>
Diffstat (limited to 'net')
-rw-r--r--net/batman-adv/translation-table.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index ec67deff1621..5852fda9f175 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -3356,8 +3356,7 @@ bool batadv_is_ap_isolated(struct batadv_priv *bat_priv, u8 *src, u8 *dst,
ret = true;
out:
- if (vlan)
- batadv_softif_vlan_free_ref(vlan);
+ batadv_softif_vlan_free_ref(vlan);
if (tt_global_entry)
batadv_tt_global_entry_free_ref(tt_global_entry);
if (tt_local_entry)