summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorMathieu Malaterre <malat@debian.org>2019-01-24 19:19:57 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-03-05 17:58:02 +0100
commit3804637933575ff9774d3bd0398b8d6bd4aed383 (patch)
tree17f75cd2090396a14d2576345cfc315a15ea7757 /net
parente9509697fd674da70401511d4b1042630d3dfaae (diff)
downloadlinux-stable-3804637933575ff9774d3bd0398b8d6bd4aed383.tar.gz
linux-stable-3804637933575ff9774d3bd0398b8d6bd4aed383.tar.bz2
linux-stable-3804637933575ff9774d3bd0398b8d6bd4aed383.zip
mac80211: Add attribute aligned(2) to struct 'action'
[ Upstream commit 7c53eb5d87bc21464da4268c3c0c47457b6d9c9b ] During refactor in commit 9e478066eae4 ("mac80211: fix MU-MIMO follow-MAC mode") a new struct 'action' was declared with packed attribute as: struct { struct ieee80211_hdr_3addr hdr; u8 category; u8 action_code; } __packed action; But since struct 'ieee80211_hdr_3addr' is declared with an aligned keyword as: struct ieee80211_hdr { __le16 frame_control; __le16 duration_id; u8 addr1[ETH_ALEN]; u8 addr2[ETH_ALEN]; u8 addr3[ETH_ALEN]; __le16 seq_ctrl; u8 addr4[ETH_ALEN]; } __packed __aligned(2); Solve the ambiguity of placing aligned structure in a packed one by adding the aligned(2) attribute to struct 'action'. This removes the following warning (W=1): net/mac80211/rx.c:234:2: warning: alignment 1 of 'struct <anonymous>' is less than 2 [-Wpacked-not-aligned] Cc: Johannes Berg <johannes.berg@intel.com> Suggested-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: Mathieu Malaterre <malat@debian.org> Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net')
-rw-r--r--net/mac80211/rx.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index dfc2af6833af..1512e547a5e0 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -206,7 +206,7 @@ static void ieee80211_handle_mu_mimo_mon(struct ieee80211_sub_if_data *sdata,
struct ieee80211_hdr_3addr hdr;
u8 category;
u8 action_code;
- } __packed action;
+ } __packed __aligned(2) action;
if (!sdata)
return;