summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorAntonio Borneo <antonio.borneo@st.com>2019-10-07 17:43:04 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-01-27 14:46:49 +0100
commit3134607b52605e595781f5083621bc7eb60e1242 (patch)
tree048bdbf043b1eda7e85810ea18a56ecb5db4c2ea /net
parenta8cfe559cb47108cc97353b65d79115cf6bf1b57 (diff)
downloadlinux-stable-3134607b52605e595781f5083621bc7eb60e1242.tar.gz
linux-stable-3134607b52605e595781f5083621bc7eb60e1242.tar.bz2
linux-stable-3134607b52605e595781f5083621bc7eb60e1242.zip
net: stmmac: fix length of PTP clock's name string
[ Upstream commit 5da202c88f8c355ad79bc2e8eb582e6d433060e7 ] The field "name" in struct ptp_clock_info has a fixed size of 16 chars and is used as zero terminated string by clock_name_show() in drivers/ptp/ptp_sysfs.c The current initialization value requires 17 chars to fit also the null termination, and this causes overflow to the next bytes in the struct when the string is read as null terminated: hexdump -C /sys/class/ptp/ptp0/clock_name 00000000 73 74 6d 6d 61 63 5f 70 74 70 5f 63 6c 6f 63 6b |stmmac_ptp_clock| 00000010 a0 ac b9 03 0a |.....| where the extra 4 bytes (excluding the newline) after the string represent the integer 0x03b9aca0 = 62500000 assigned to the field "max_adj" that follows "name" in the same struct. There is no strict requirement for the "name" content and in the comment in ptp_clock_kernel.h it's reported it should just be 'A short "friendly name" to identify the clock'. Replace it with "stmmac ptp". Signed-off-by: Antonio Borneo <antonio.borneo@st.com> Fixes: 92ba6888510c ("stmmac: add the support for PTP hw clock driver") Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions