diff options
| author | Hangyu Hua <hbh25y@gmail.com> | 2021-12-09 16:28:39 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-11 13:58:50 +0100 |
| commit | 4dece2760af408ad91d6e43afc485d20386c2885 (patch) | |
| tree | 7dd6b3d55b0c473a46d74a8b7121d9bb4494486b /net | |
| parent | ac1e082af462e477bee414bd22c843854cbcb60d (diff) | |
| download | linux-stable-4dece2760af408ad91d6e43afc485d20386c2885.tar.gz linux-stable-4dece2760af408ad91d6e43afc485d20386c2885.tar.bz2 linux-stable-4dece2760af408ad91d6e43afc485d20386c2885.zip | |
phonet: refcount leak in pep_sock_accep
commit bcd0f93353326954817a4f9fa55ec57fb38acbb0 upstream.
sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not
invoked in subsequent failure branches(pep_accept_conn() != 0).
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20211209082839.33985-1-hbh25y@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Aayush Agarwal <aayush.a.agarwal@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/phonet/pep.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/phonet/pep.c b/net/phonet/pep.c index c0b4cc1e108b..fe01cc788448 100644 --- a/net/phonet/pep.c +++ b/net/phonet/pep.c @@ -881,6 +881,7 @@ static struct sock *pep_sock_accept(struct sock *sk, int flags, int *errp, err = pep_accept_conn(newsk, skb); if (err) { + __sock_put(sk); sock_put(newsk); newsk = NULL; goto drop; |