diff options
author | Daniil Tatianin <d-tatianin@yandex-team.ru> | 2022-12-26 14:48:23 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-01-24 07:11:49 +0100 |
commit | 2cf8dd47089fed40b263fb26be58e4e4da28a8a8 (patch) | |
tree | a90c6c6979bf53356839b21ca76a4890fa9646a3 /net | |
parent | d22031d040bdab4c2ad1add0cd0aeabaf8100ce5 (diff) | |
download | linux-stable-2cf8dd47089fed40b263fb26be58e4e4da28a8a8.tar.gz linux-stable-2cf8dd47089fed40b263fb26be58e4e4da28a8a8.tar.bz2 linux-stable-2cf8dd47089fed40b263fb26be58e4e4da28a8a8.zip |
net/ethtool/ioctl: return -EOPNOTSUPP if we have no phy stats
[ Upstream commit 9deb1e9fb88b1120a908676fa33bdf9e2eeaefce ]
It's not very useful to copy back an empty ethtool_stats struct and
return 0 if we didn't actually have any stats. This also allows for
further simplification of this function in the future commits.
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net')
-rw-r--r-- | net/core/ethtool.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 4db9512feba8..d007f1cca64c 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -2023,7 +2023,8 @@ static int ethtool_get_phy_stats(struct net_device *dev, void __user *useraddr) return n_stats; if (n_stats > S32_MAX / sizeof(u64)) return -ENOMEM; - WARN_ON_ONCE(!n_stats); + if (WARN_ON_ONCE(!n_stats)) + return -EOPNOTSUPP; if (copy_from_user(&stats, useraddr, sizeof(stats))) return -EFAULT; |