diff options
| author | Eric Dumazet <edumazet@google.com> | 2019-04-22 18:35:01 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-04-23 17:19:48 -0700 |
| commit | b0270550229b3efeadfcac1cf04415dfea27915e (patch) | |
| tree | 7ab580f7899eddeeb9351f3249271a2d753fba5a /net | |
| parent | 20eb08b2b06bf1cf5e5dda2e5212db893c3e8ffe (diff) | |
| download | linux-stable-b0270550229b3efeadfcac1cf04415dfea27915e.tar.gz linux-stable-b0270550229b3efeadfcac1cf04415dfea27915e.tar.bz2 linux-stable-b0270550229b3efeadfcac1cf04415dfea27915e.zip | |
ipv6: fib6_info_destroy_rcu() cleanup
We do not need to clear f6i->rt6i_exception_bucket right before
freeing f6i.
Note that f6i->rt6i_exception_bucket is properly protected by
f6i->exception_bucket_flushed being set to one in rt6_flush_exceptions()
under the protection of rt6_exception_lock.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Wei Wang <weiwan@google.com>
Acked-by: Wei Wang <weiwan@google.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv6/ip6_fib.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index b47e15df9769..551938591529 100644 --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c @@ -175,10 +175,7 @@ void fib6_info_destroy_rcu(struct rcu_head *head) WARN_ON(f6i->fib6_node); bucket = rcu_dereference_protected(f6i->rt6i_exception_bucket, 1); - if (bucket) { - f6i->rt6i_exception_bucket = NULL; - kfree(bucket); - } + kfree(bucket); if (f6i->rt6i_pcpu) { int cpu; |