diff options
| author | Cong Wang <xiyou.wangcong@gmail.com> | 2019-09-08 12:11:23 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-01 09:01:45 +0200 |
| commit | 719532b9b83211febd34a1a5b1aa28c5469a0697 (patch) | |
| tree | 328a218bf1a14663e980c92498986563176c17b7 /net | |
| parent | bd740eacb1d2034331cc5ec48e73fe45c6a06d85 (diff) | |
| download | linux-stable-719532b9b83211febd34a1a5b1aa28c5469a0697.tar.gz linux-stable-719532b9b83211febd34a1a5b1aa28c5469a0697.tar.bz2 linux-stable-719532b9b83211febd34a1a5b1aa28c5469a0697.zip | |
net_sched: check cops->tcf_block in tc_bind_tclass()
[ Upstream commit 8b142a00edcf8422ca48b8de88d286efb500cb53 ]
At least sch_red and sch_tbf don't implement ->tcf_block()
while still have a non-zero tc "class".
Instead of adding nop implementations to each of such qdisc's,
we can just relax the check of cops->tcf_block() in
tc_bind_tclass(). They don't support TC filter anyway.
Reported-by: syzbot+21b29db13c065852f64b@syzkaller.appspotmail.com
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sched/sch_api.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index 04faee7ccbce..1047825d9f48 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -1920,6 +1920,8 @@ static void tc_bind_tclass(struct Qdisc *q, u32 portid, u32 clid, cl = cops->find(q, portid); if (!cl) return; + if (!cops->tcf_block) + return; block = cops->tcf_block(q, cl, NULL); if (!block) return; |