diff options
author | Hangbin Liu <liuhangbin@gmail.com> | 2018-04-27 20:59:24 +0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-05-19 10:20:23 +0200 |
commit | 2c13a91e0fc52fcba83dbdacbdfaf07de1a4f44f (patch) | |
tree | 04612a999835440f2d21cc5f390ba78b571a6047 /samples/connector | |
parent | ece94a76618e1df547ea99544fb69de5a5079633 (diff) | |
download | linux-stable-2c13a91e0fc52fcba83dbdacbdfaf07de1a4f44f.tar.gz linux-stable-2c13a91e0fc52fcba83dbdacbdfaf07de1a4f44f.tar.bz2 linux-stable-2c13a91e0fc52fcba83dbdacbdfaf07de1a4f44f.zip |
bridge: check iface upper dev when setting master via ioctl
[ Upstream commit e8238fc2bd7b4c3c7554fa2df067e796610212fc ]
When we set a bond slave's master to bridge via ioctl, we only check
the IFF_BRIDGE_PORT flag. Although we will find the slave's real master
at netdev_master_upper_dev_link() later, it already does some settings
and allocates some resources. It would be better to return as early
as possible.
v1 -> v2:
use netdev_master_upper_dev_get() instead of netdev_has_any_upper_dev()
to check if we have a master, because not all upper devs are masters,
e.g. vlan device.
Reported-by: syzbot+de73361ee4971b6e6f75@syzkaller.appspotmail.com
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'samples/connector')
0 files changed, 0 insertions, 0 deletions