diff options
| author | Joe Perches <joe@perches.com> | 2012-07-30 14:41:22 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-07-30 17:25:17 -0700 |
| commit | 66c80b6077256898df948ac6acf547b47ddb1fcf (patch) | |
| tree | 20982260f1fd1e875188b24ddd598e77544e5354 /scripts/checkpatch.pl | |
| parent | 4a273195a551a27a9a3ebed072c8df16c853da7f (diff) | |
| download | linux-stable-66c80b6077256898df948ac6acf547b47ddb1fcf.tar.gz linux-stable-66c80b6077256898df948ac6acf547b47ddb1fcf.tar.bz2 linux-stable-66c80b6077256898df948ac6acf547b47ddb1fcf.zip | |
checkpatch: Add acheck for use of sizeof without parenthesis
Kernel style uses parenthesis around sizeof.
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/checkpatch.pl')
| -rwxr-xr-x | scripts/checkpatch.pl | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 4bad5700670a..40b0627aeb5e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3265,6 +3265,12 @@ sub process { "sizeof(& should be avoided\n" . $herecurr); } +# check for sizeof without parenthesis + if ($line =~ /\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/) { + WARN("SIZEOF_PARENTHESIS", + "sizeof $1 should be sizeof($1)\n" . $herecurr); + } + # check for line continuations in quoted strings with odd counts of " if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) { WARN("LINE_CONTINUATIONS", |