diff options
| author | Kees Cook <keescook@chromium.org> | 2021-09-29 15:02:18 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-11-17 09:48:31 +0100 |
| commit | 2226ad031436668ca709365e7fc906eae99945ff (patch) | |
| tree | 68fb27dc093daa1f2d53e71814066d25d15ad20d /scripts/leaking_addresses.pl | |
| parent | 63c3c7b699d25bc932ce9767367ba17e492e155e (diff) | |
| download | linux-stable-2226ad031436668ca709365e7fc906eae99945ff.tar.gz linux-stable-2226ad031436668ca709365e7fc906eae99945ff.tar.bz2 linux-stable-2226ad031436668ca709365e7fc906eae99945ff.zip | |
leaking_addresses: Always print a trailing newline
[ Upstream commit cf2a85efdade117e2169d6e26641016cbbf03ef0 ]
For files that lack trailing newlines and match a leaking address (e.g.
wchan[1]), the leaking_addresses.pl report would run together with the
next line, making things look corrupted.
Unconditionally remove the newline on input, and write it back out on
output.
[1] https://lore.kernel.org/all/20210103142726.GC30643@xsang-OptiPlex-9020/
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20211008111626.151570317@infradead.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'scripts/leaking_addresses.pl')
| -rwxr-xr-x | scripts/leaking_addresses.pl | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl index b2d8b8aa2d99..8f636a23bc3f 100755 --- a/scripts/leaking_addresses.pl +++ b/scripts/leaking_addresses.pl @@ -455,8 +455,9 @@ sub parse_file open my $fh, "<", $file or return; while ( <$fh> ) { + chomp; if (may_leak_address($_)) { - print $file . ': ' . $_; + printf("$file: $_\n"); } } close $fh; |