summaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2018-02-03 08:44:58 +0100
committerMasahiro Yamada <yamada.masahiro@socionext.com>2018-02-08 00:16:12 +0900
commita2b0fe7435faee6f6fbb27409878013bc4727e98 (patch)
tree38e8875a759e3ed8150d066c3a98600d6e7e5050 /scripts
parente856f3a7d706b37d8be9b41e41b19f4919570e57 (diff)
downloadlinux-stable-a2b0fe7435faee6f6fbb27409878013bc4727e98.tar.gz
linux-stable-a2b0fe7435faee6f6fbb27409878013bc4727e98.tar.bz2
linux-stable-a2b0fe7435faee6f6fbb27409878013bc4727e98.zip
coccinelle: deref_null: avoid useless computation
The effect of the rules ifm1, pr11, and pr12 is only used in the final rule, which depends on context && !org && !report. Thus these rules should only be performed in those circumstances. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Diffstat (limited to 'scripts')
-rw-r--r--scripts/coccinelle/null/deref_null.cocci6
1 files changed, 3 insertions, 3 deletions
diff --git a/scripts/coccinelle/null/deref_null.cocci b/scripts/coccinelle/null/deref_null.cocci
index f192d6035d02..b16ccb7663a7 100644
--- a/scripts/coccinelle/null/deref_null.cocci
+++ b/scripts/coccinelle/null/deref_null.cocci
@@ -212,7 +212,7 @@ else S3
// The following three rules are duplicates of ifm, pr1 and pr2 respectively.
// It is need because the previous rule as already made a "change".
-@ifm1@
+@ifm1 depends on context && !org && !report@
expression *E;
statement S1,S2;
position p1;
@@ -220,7 +220,7 @@ position p1;
if@p1 ((E == NULL && ...) || ...) S1 else S2
-@pr11 expression@
+@pr11 depends on context && !org && !report expression@
expression *ifm1.E;
identifier f;
position p1;
@@ -228,7 +228,7 @@ position p1;
(E != NULL && ...) ? <+...E->f@p1...+> : ...
-@pr12 expression@
+@pr12 depends on context && !org && !report expression@
expression *ifm1.E;
identifier f;
position p2;