summaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authorMasahiro Yamada <masahiroy@kernel.org>2022-01-10 03:15:25 +0900
committerMasahiro Yamada <masahiroy@kernel.org>2022-01-14 02:50:29 +0900
commit82977af93a0dc4e70f60ca2137b67f65ebe47fc7 (patch)
tree41ce80ec025d7bbca8bfd20fc223cea4536c1b0a /scripts
parentc199d5d0a79d4eb11623e0eb645b27d271f8d713 (diff)
downloadlinux-stable-82977af93a0dc4e70f60ca2137b67f65ebe47fc7.tar.gz
linux-stable-82977af93a0dc4e70f60ca2137b67f65ebe47fc7.tar.bz2
linux-stable-82977af93a0dc4e70f60ca2137b67f65ebe47fc7.zip
sh: rename suffix-y to suffix_y
'export suffix-y' does not work reliably because hyphens are disallowed in shell variables. A similar issue was fixed by commit 2bfbe7881ee0 ("kbuild: Do not use hyphen in exported variable name"). If I do similar in dash, ARCH=sh fails to build. $ mv linux linux~ $ cd linux~ $ dash $ make O=foo/bar ARCH=sh CROSS_COMPILE=sh4-linux-gnu- defconfig all make[1]: Entering directory '/home/masahiro/linux~/foo/bar' [ snip ] make[4]: *** No rule to make target 'arch/sh/boot/compressed/vmlinux.bin.', needed by 'arch/sh/boot/compressed/piggy.o'. Stop. make[3]: *** [/home/masahiro/linux~/arch/sh/boot/Makefile:40: arch/sh/boot/compressed/vmlinux] Error 2 make[2]: *** [/home/masahiro/linux~/arch/sh/Makefile:194: zImage] Error 2 make[1]: *** [/home/masahiro/linux~/Makefile:350: __build_one_by_one] Error 2 make[1]: Leaving directory '/home/masahiro/linux~/foo/bar' make: *** [Makefile:219: __sub-make] Error 2 The maintainer of GNU Make stated that there is no consistent way to export variables that do not meet the shell's naming criteria. (https://savannah.gnu.org/bugs/?55719) Consequently, you cannot use hyphens in exported variables. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Nicolas Schier <n.schier@avm.de>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions