diff options
author | Takashi Iwai <tiwai@suse.de> | 2018-01-10 23:48:05 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-01-31 14:46:11 +0100 |
commit | cdbebd4716bc50d2d965fdefc16d007239402197 (patch) | |
tree | c101d09ae22c427f996fdedfbcaf6e4f662e6fc0 /sound/pci | |
parent | ad211e59c68389b9203f3834c65da7bfe9e6874a (diff) | |
download | linux-stable-cdbebd4716bc50d2d965fdefc16d007239402197.tar.gz linux-stable-cdbebd4716bc50d2d965fdefc16d007239402197.tar.bz2 linux-stable-cdbebd4716bc50d2d965fdefc16d007239402197.zip |
ALSA: pcm: Remove yet superfluous WARN_ON()
commit 23b19b7b50fe1867da8d431eea9cd3e4b6328c2c upstream.
muldiv32() contains a snd_BUG_ON() (which is morphed as WARN_ON() with
debug option) for checking the case of 0 / 0. This would be helpful
if this happens only as a logical error; however, since the hw refine
is performed with any data set provided by user, the inconsistent
values that can trigger such a condition might be passed easily.
Actually, syzbot caught this by passing some zero'ed old hw_params
ioctl.
So, having snd_BUG_ON() there is simply superfluous and rather
harmful to give unnecessary confusions. Let's get rid of it.
Reported-by: syzbot+7e6ee55011deeebce15d@syzkaller.appspotmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/pci')
0 files changed, 0 insertions, 0 deletions