diff options
author | Lars-Peter Clausen <lars@metafoo.de> | 2014-02-17 13:16:54 +0100 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2014-02-18 10:04:37 +0900 |
commit | 6c3d713e6d32706999689e379a9098afb4cd8a2c (patch) | |
tree | 7f26da80df69fbd48f53835924be036f161f63f3 /sound/soc/codecs/ad193x.h | |
parent | 38dbfb59d1175ef458d006556061adeaa8751b72 (diff) | |
download | linux-stable-6c3d713e6d32706999689e379a9098afb4cd8a2c.tar.gz linux-stable-6c3d713e6d32706999689e379a9098afb4cd8a2c.tar.bz2 linux-stable-6c3d713e6d32706999689e379a9098afb4cd8a2c.zip |
ASoC: ad193x: Split SPI and I2C code into different modules
There are a few known (minor) problems with having the support code for both I2C
and SPI in the same module:
* We need to be extra careful to make sure to not build the driver into the
kernel if one of the subsystems is build as a module (Currently only I2C
can be build as a module).
* The module init path error handling is rather ugly. E.g. what should be
done if either the SPI or the I2C driver fails to register? Most drivers
that implement SPI and I2C in the same module currently fallback to
undefined behavior in that case. Splitting the the driver into two
modules, one for each bus, allows the registration of the other bus driver
to continue without problems if one of them fails.
This patch splits the AD193X driver into 3 modules. One core module that
implements the device logic, but is independent of the bus method used. And one
module for SPI and I2C each that registers the drivers and sets up the regmap
struct for the bus.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'sound/soc/codecs/ad193x.h')
-rw-r--r-- | sound/soc/codecs/ad193x.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/sound/soc/codecs/ad193x.h b/sound/soc/codecs/ad193x.h index 473388049992..ab9a998f15be 100644 --- a/sound/soc/codecs/ad193x.h +++ b/sound/soc/codecs/ad193x.h @@ -9,6 +9,13 @@ #ifndef __AD193X_H__ #define __AD193X_H__ +#include <linux/regmap.h> + +struct device; + +extern const struct regmap_config ad193x_regmap_config; +int ad193x_probe(struct device *dev, struct regmap *regmap); + #define AD193X_PLL_CLK_CTRL0 0x00 #define AD193X_PLL_POWERDOWN 0x01 #define AD193X_PLL_INPUT_MASK 0x6 |