diff options
author | Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> | 2020-11-19 08:50:09 +0900 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2020-11-26 13:09:35 +0000 |
commit | f94ba9ac20fab9af08240fde3741edf73655411d (patch) | |
tree | f27341b5f5e27d95d3b128650140b2aa10680c35 /sound/soc/soc-link.c | |
parent | 1e6a93cf74979e167cef8d29f6689705d9ec6735 (diff) | |
download | linux-stable-f94ba9ac20fab9af08240fde3741edf73655411d.tar.gz linux-stable-f94ba9ac20fab9af08240fde3741edf73655411d.tar.bz2 linux-stable-f94ba9ac20fab9af08240fde3741edf73655411d.zip |
ASoC: soc-component: add mark for snd_soc_component_compr_open/free()
soc_compr_open() does rollback when failed (A),
but, it is almost same as soc_compr_free().
static int soc_compr_open(xxx)
{
...
if (ret < 0)
goto xxx_err;
...
return 0;
^ machine_err:
| ...
| out:
(A) ...
| pm_err:
| ...
v return ret;
}
The difference is
soc_compr_free() is for all dai/component/substream,
rollback is for succeeded part only.
This kind of duplicated code can be a hotbed of bugs,
thus, we want to share soc_compr_free() and rollback.
1) snd_soc_dai_compr_startup/shutdown()
=> 2) snd_soc_component_compr_open/free()
3) snd_soc_link_compr_startup/shutdown()
This patch is for 2) snd_soc_component_compr_open/free(),
and adds new cstream mark.
It will mark cstream when startup() was suceeded.
If rollback happen *after* that, it will check rollback flag
and marked cstream.
It cares *previous* startup() only now,
but we might want to check *whole* marked cstream in the future.
This patch is using macro so that it can be easily adjust to it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87lfey5iwk.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/soc-link.c')
0 files changed, 0 insertions, 0 deletions