diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2019-06-28 13:11:49 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-07-21 09:00:39 +0200 |
commit | 5db47f4300fafb8f9bf2c95036160f76d5ce73f5 (patch) | |
tree | 9de4ebbb7df46a1463cd46b096bd9877f44586bf /sound | |
parent | 5f1733eaeccc95e8ae7dfa38a9026c68e6d55257 (diff) | |
download | linux-stable-5db47f4300fafb8f9bf2c95036160f76d5ce73f5.tar.gz linux-stable-5db47f4300fafb8f9bf2c95036160f76d5ce73f5.tar.bz2 linux-stable-5db47f4300fafb8f9bf2c95036160f76d5ce73f5.zip |
genirq: Delay deactivation in free_irq()
commit 4001d8e8762f57d418b66e4e668601791900a1dd upstream.
When interrupts are shutdown, they are immediately deactivated in the
irqdomain hierarchy. While this looks obviously correct there is a subtle
issue:
There might be an interrupt in flight when free_irq() is invoking the
shutdown. This is properly handled at the irq descriptor / primary handler
level, but the deactivation might completely disable resources which are
required to acknowledge the interrupt.
Split the shutdown code and deactivate the interrupt after synchronization
in free_irq(). Fixup all other usage sites where this is not an issue to
invoke the combined shutdown_and_deactivate() function instead.
This still might be an issue if the interrupt in flight servicing is
delayed on a remote CPU beyond the invocation of synchronize_irq(), but
that cannot be handled at that level and needs to be handled in the
synchronize_irq() context.
Fixes: f8264e34965a ("irqdomain: Introduce new interfaces to support hierarchy irqdomains")
Reported-by: Robert Hodaszi <Robert.Hodaszi@digi.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
Link: https://lkml.kernel.org/r/20190628111440.098196390@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound')
0 files changed, 0 insertions, 0 deletions