diff options
author | Takashi Iwai <tiwai@suse.de> | 2016-01-18 14:12:40 +0100 |
---|---|---|
committer | Ben Hutchings <ben@decadent.org.uk> | 2016-02-13 10:34:11 +0000 |
commit | c793373eea1dcd0102a4f09edea14d404da9629b (patch) | |
tree | 72ccf73ad712606175c270dddf209ba49e3f0976 /sound | |
parent | 2652a5cb46b8e55c2e62aef48256c31af0127420 (diff) | |
download | linux-stable-c793373eea1dcd0102a4f09edea14d404da9629b.tar.gz linux-stable-c793373eea1dcd0102a4f09edea14d404da9629b.tar.bz2 linux-stable-c793373eea1dcd0102a4f09edea14d404da9629b.zip |
ALSA: control: Avoid kernel warnings from tlv ioctl with numid 0
commit c0bcdbdff3ff73a54161fca3cb8b6cdbd0bb8762 upstream.
When a TLV ioctl with numid zero is handled, the driver may spew a
kernel warning with a stack trace at each call. The check was
intended obviously only for a kernel driver, but not for a user
interaction. Let's fix it.
This was spotted by syzkaller fuzzer.
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'sound')
-rw-r--r-- | sound/core/control.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/core/control.c b/sound/core/control.c index 1ba5d339acd3..96c62e58d950 100644 --- a/sound/core/control.c +++ b/sound/core/control.c @@ -1321,6 +1321,8 @@ static int snd_ctl_tlv_ioctl(struct snd_ctl_file *file, return -EFAULT; if (tlv.length < sizeof(unsigned int) * 2) return -EINVAL; + if (!tlv.numid) + return -EINVAL; down_read(&card->controls_rwsem); kctl = snd_ctl_find_numid(card, tlv.numid); if (kctl == NULL) { |