summaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorKangjie Lu <kjlu@umn.edu>2019-03-14 23:04:14 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-04-20 09:07:47 +0200
commit5e6e33fd757714e76d7abeddac125547bb2cf20d (patch)
treeb4c30bdffe28a0cddc5befece368e2f6fabc4b0e /sound
parenta3e47ff19026e6f11df466ae4325e51b985bcc47 (diff)
downloadlinux-stable-5e6e33fd757714e76d7abeddac125547bb2cf20d.tar.gz
linux-stable-5e6e33fd757714e76d7abeddac125547bb2cf20d.tar.bz2
linux-stable-5e6e33fd757714e76d7abeddac125547bb2cf20d.zip
ALSA: sb8: add a check for request_region
[ Upstream commit dcd0feac9bab901d5739de51b3f69840851f8919 ] In case request_region fails, the fix returns an error code to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu <kjlu@umn.edu> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'sound')
-rw-r--r--sound/isa/sb/sb8.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c
index ad42d2364199..e75bfc511e3e 100644
--- a/sound/isa/sb/sb8.c
+++ b/sound/isa/sb/sb8.c
@@ -111,6 +111,10 @@ static int snd_sb8_probe(struct device *pdev, unsigned int dev)
/* block the 0x388 port to avoid PnP conflicts */
acard->fm_res = request_region(0x388, 4, "SoundBlaster FM");
+ if (!acard->fm_res) {
+ err = -EBUSY;
+ goto _err;
+ }
if (port[dev] != SNDRV_AUTO_PORT) {
if ((err = snd_sbdsp_create(card, port[dev], irq[dev],