diff options
| author | Chuhong Yuan <hslester96@gmail.com> | 2019-11-18 15:36:33 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-11-18 13:02:36 +0000 |
| commit | 2dab09be49a1e7a4dd13cb47d3a1441a2ef33a87 (patch) | |
| tree | 8c88f6d9152f96858ddf1907de4f1c62c2dae848 /sound | |
| parent | baddcee989931e304eeb90c101751c2f7f9b5045 (diff) | |
| download | linux-stable-2dab09be49a1e7a4dd13cb47d3a1441a2ef33a87.tar.gz linux-stable-2dab09be49a1e7a4dd13cb47d3a1441a2ef33a87.tar.bz2 linux-stable-2dab09be49a1e7a4dd13cb47d3a1441a2ef33a87.zip | |
ASoC: wm2200: add missed operations in remove and probe failure
This driver misses calls to pm_runtime_disable and regulator_bulk_disable
in remove and a call to free_irq in probe failure.
Add the calls to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Link: https://lore.kernel.org/r/20191118073633.28237-1-hslester96@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/codecs/wm2200.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/sound/soc/codecs/wm2200.c b/sound/soc/codecs/wm2200.c index cf64e109c658..7b087d94141b 100644 --- a/sound/soc/codecs/wm2200.c +++ b/sound/soc/codecs/wm2200.c @@ -2410,6 +2410,8 @@ static int wm2200_i2c_probe(struct i2c_client *i2c, err_pm_runtime: pm_runtime_disable(&i2c->dev); + if (i2c->irq) + free_irq(i2c->irq, wm2200); err_reset: if (wm2200->pdata.reset) gpio_set_value_cansleep(wm2200->pdata.reset, 0); @@ -2426,12 +2428,15 @@ static int wm2200_i2c_remove(struct i2c_client *i2c) { struct wm2200_priv *wm2200 = i2c_get_clientdata(i2c); + pm_runtime_disable(&i2c->dev); if (i2c->irq) free_irq(i2c->irq, wm2200); if (wm2200->pdata.reset) gpio_set_value_cansleep(wm2200->pdata.reset, 0); if (wm2200->pdata.ldo_ena) gpio_set_value_cansleep(wm2200->pdata.ldo_ena, 0); + regulator_bulk_disable(ARRAY_SIZE(wm2200->core_supplies), + wm2200->core_supplies); return 0; } |