summaryrefslogtreecommitdiffstats
path: root/tools/objtool/special.h
diff options
context:
space:
mode:
authorPeter Zijlstra <peterz@infradead.org>2019-02-25 12:50:09 +0100
committerIngo Molnar <mingo@kernel.org>2019-04-03 11:02:24 +0200
commitea24213d8088f9da73e1b6aadf7abd2435b70397 (patch)
treefba1e181531f8f20ff04ed6a57e10b8bd2805343 /tools/objtool/special.h
parent54262aa2830151f89699fa8a6c5aa05f0992e672 (diff)
downloadlinux-stable-ea24213d8088f9da73e1b6aadf7abd2435b70397.tar.gz
linux-stable-ea24213d8088f9da73e1b6aadf7abd2435b70397.tar.bz2
linux-stable-ea24213d8088f9da73e1b6aadf7abd2435b70397.zip
objtool: Add UACCESS validation
It is important that UACCESS regions are as small as possible; furthermore the UACCESS state is not scheduled, so doing anything that might directly call into the scheduler will cause random code to be ran with UACCESS enabled. Teach objtool too track UACCESS state and warn about any CALL made while UACCESS is enabled. This very much includes the __fentry__() and __preempt_schedule() calls. Note that exceptions _do_ save/restore the UACCESS state, and therefore they can drive preemption. This also means that all exception handlers must have an otherwise redundant UACCESS disable instruction; therefore ignore this warning for !STT_FUNC code (exception handlers are not normal functions). Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'tools/objtool/special.h')
-rw-r--r--tools/objtool/special.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/objtool/special.h b/tools/objtool/special.h
index fad1d092f679..d5c062e718ef 100644
--- a/tools/objtool/special.h
+++ b/tools/objtool/special.h
@@ -26,6 +26,7 @@ struct special_alt {
bool group;
bool skip_orig;
+ bool skip_alt;
bool jump_or_nop;
struct section *orig_sec;