diff options
| author | Paolo Abeni <pabeni@redhat.com> | 2023-11-16 18:01:41 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-11-17 02:47:19 +0000 |
| commit | 75a50c4f5b957a34dedb7c8cce52b582a9162828 (patch) | |
| tree | fee929055b875c478c9e6e32f10355097d0fde0c /tools/testing/selftests/net/rtnetlink.sh | |
| parent | d565fa4300d9ebd5ba3bbd259ce841f8dab609d6 (diff) | |
| download | linux-stable-75a50c4f5b957a34dedb7c8cce52b582a9162828.tar.gz linux-stable-75a50c4f5b957a34dedb7c8cce52b582a9162828.tar.bz2 linux-stable-75a50c4f5b957a34dedb7c8cce52b582a9162828.zip | |
kselftest: rtnetlink: fix ip route command typo
The blamed commit below introduced a typo causing 'gretap' test-case
failures:
./rtnetlink.sh -t kci_test_gretap -v
COMMAND: ip link add name test-dummy0 type dummy
COMMAND: ip link set test-dummy0 up
COMMAND: ip netns add testns
COMMAND: ip link help gretap 2>&1 | grep -q '^Usage:'
COMMAND: ip -netns testns link add dev gretap00 type gretap seq key 102 local 172.16.1.100 remote 172.16.1.200
COMMAND: ip -netns testns addr add dev gretap00 10.1.1.100/24
COMMAND: ip -netns testns link set dev gretap00 ups
Error: either "dev" is duplicate, or "ups" is a garbage.
COMMAND: ip -netns testns link del gretap00
COMMAND: ip -netns testns link add dev gretap00 type gretap external
COMMAND: ip -netns testns link del gretap00
FAIL: gretap
Fix it by using the correct keyword.
Fixes: 9c2a19f71515 ("kselftest: rtnetlink.sh: add verbose flag")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing/selftests/net/rtnetlink.sh')
| -rwxr-xr-x | tools/testing/selftests/net/rtnetlink.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh index 5f2b3f6c0d74..38be9706c45f 100755 --- a/tools/testing/selftests/net/rtnetlink.sh +++ b/tools/testing/selftests/net/rtnetlink.sh @@ -859,7 +859,7 @@ kci_test_gretap() run_cmd ip -netns "$testns" addr add dev "$DEV_NS" 10.1.1.100/24 - run_cmd ip -netns "$testns" link set dev $DEV_NS ups + run_cmd ip -netns "$testns" link set dev $DEV_NS up run_cmd ip -netns "$testns" link del "$DEV_NS" # test external mode |