diff options
| author | Tony Jones <tonyj@suse.de> | 2019-02-27 17:55:32 -0800 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2019-07-09 22:04:09 +0100 |
| commit | 5b4f9ccfd4565b156f11aa4dffdb6c69a290b918 (patch) | |
| tree | c355829689a8570515c4e8440003751517173c3d /tools | |
| parent | 3078ec66dcb95f1133680f4bf4cfee4de90f90ee (diff) | |
| download | linux-stable-5b4f9ccfd4565b156f11aa4dffdb6c69a290b918.tar.gz linux-stable-5b4f9ccfd4565b156f11aa4dffdb6c69a290b918.tar.bz2 linux-stable-5b4f9ccfd4565b156f11aa4dffdb6c69a290b918.zip | |
tools lib traceevent: Fix buffer overflow in arg_eval
commit 7c5b019e3a638a5a290b0ec020f6ca83d2ec2aaa upstream.
Fix buffer overflow observed when running perf test.
The overflow is when trying to evaluate "1ULL << (64 - 1)" which is
resulting in -9223372036854775808 which overflows the 20 character
buffer.
If is possible this bug has been reported before but I still don't see
any fix checked in:
See: https://www.spinics.net/lists/linux-perf-users/msg07714.html
Reported-by: Michael Sartain <mikesart@fastmail.com>
Reported-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: Tony Jones <tonyj@suse.de>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Fixes: f7d82350e597 ("tools/events: Add files to create libtraceevent.a")
Link: http://lkml.kernel.org/r/20190228015532.8941-1-tonyj@suse.de
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/lib/traceevent/event-parse.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index 6b8769a40acb..95b2df232d71 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -2283,7 +2283,7 @@ static int arg_num_eval(struct print_arg *arg, long long *val) static char *arg_eval (struct print_arg *arg) { long long val; - static char buf[20]; + static char buf[24]; switch (arg->type) { case PRINT_ATOM: |