summaryrefslogtreecommitdiffstats
path: root/usr
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2020-04-14 15:33:13 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-04-16 14:52:09 +0200
commit97341ef7070d984305aaefe8b713491e3213d6ab (patch)
treed90b25575e065da48b2168120ee767379bb900ac /usr
parent7dbdb53d72a51cea9b921d9dbba54be00752212a (diff)
downloadlinux-stable-97341ef7070d984305aaefe8b713491e3213d6ab.tar.gz
linux-stable-97341ef7070d984305aaefe8b713491e3213d6ab.tar.bz2
linux-stable-97341ef7070d984305aaefe8b713491e3213d6ab.zip
usb: typec: pi3usb30532: Set switch_ / mux_desc name field to NULL
Since commit ef441dd6af91 ("usb: typec: mux: Allow the muxes to be named") the typec_switch_desc and typec_mux_desc structs contain a name field. The pi3usb30532 driver allocates these structs on the stack and so far did not explicitly zero the mem used for the structs. This causes the new name fields to point to a random memory address, which in my test case happens to be a valid address leading to "interesting" mux / switch names: [root@localhost ~]# ls -l /sys/class/typec_mux/ total 0 lrwxrwxrwx. 1 root root 0 Apr 14 12:55 ''$'\r''-switch' -> ... lrwxrwxrwx. 1 root root 0 Apr 14 12:55 ''$'\320\302\006''2'$'... Explicitly initialize the structs to zero when declaring them on the stack so that any unused fields get set to 0, fixing this. Fixes: ef441dd6af91 ("usb: typec: mux: Allow the muxes to be named") Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/20200414133313.131802-1-hdegoede@redhat.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'usr')
0 files changed, 0 insertions, 0 deletions