diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2016-03-10 20:42:08 +0100 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2016-03-10 21:21:59 +0100 |
commit | 2a58c527bb566b7abad96289fa5b973040c33c82 (patch) | |
tree | 5f22c738d4a79fb4ed816e3453445f55d0e6626e /virt | |
parent | 5d8eb84253333f8f63ec704276e3f0a8ec8f3189 (diff) | |
download | linux-stable-2a58c527bb566b7abad96289fa5b973040c33c82.tar.gz linux-stable-2a58c527bb566b7abad96289fa5b973040c33c82.tar.bz2 linux-stable-2a58c527bb566b7abad96289fa5b973040c33c82.zip |
cpu/hotplug: Fix smpboot thread ordering
Commit 931ef163309e moved the smpboot thread park/unpark invocation to the
state machine. The move of the unpark invocation was premature as it depends
on work in progress patches.
As a result cpu down can fail, because rcu synchronization in takedown_cpu()
eventually requires a functional softirq thread. I never encountered the
problem in testing, but 0day testing managed to provide a reliable reproducer.
Remove the smpboot_threads_park() call from the state machine for now and put
it back into the original place after the rcu synchronization.
I'm embarrassed as I knew about the dependency and still managed to get it
wrong. Hotplug induced brain melt seems to be the only sensible explanation
for that.
Fixes: 931ef163309e "cpu/hotplug: Unpark smpboot threads from the state machine"
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Diffstat (limited to 'virt')
0 files changed, 0 insertions, 0 deletions