summaryrefslogtreecommitdiffstats
path: root/virt
diff options
context:
space:
mode:
authorMiaohe Lin <linmiaohe@huawei.com>2022-08-23 14:34:14 +0800
committerPaolo Bonzini <pbonzini@redhat.com>2022-09-26 12:02:27 -0400
commit5a2a961be2ad6a16eb388a80442443b353c11d16 (patch)
treef15f680752824569aae3098a357956056d099bf2 /virt
parentd38ba8ccd9c22b177d50f896a1bdc2f0979b343f (diff)
downloadlinux-stable-5a2a961be2ad6a16eb388a80442443b353c11d16.tar.gz
linux-stable-5a2a961be2ad6a16eb388a80442443b353c11d16.tar.bz2
linux-stable-5a2a961be2ad6a16eb388a80442443b353c11d16.zip
KVM: fix memoryleak in kvm_init()
When alloc_cpumask_var_node() fails for a certain cpu, there might be some allocated cpumasks for percpu cpu_kick_mask. We should free these cpumasks or memoryleak will occur. Fixes: baff59ccdc65 ("KVM: Pre-allocate cpumasks for kvm_make_all_cpus_request_except()") Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Link: https://lore.kernel.org/r/20220823063414.59778-1-linmiaohe@huawei.com Signed-off-by: Sean Christopherson <seanjc@google.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'virt')
-rw-r--r--virt/kvm/kvm_main.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 584a5bab3af3..dcf47da44844 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -5881,7 +5881,7 @@ int kvm_init(void *opaque, unsigned vcpu_size, unsigned vcpu_align,
r = kvm_async_pf_init();
if (r)
- goto out_free_5;
+ goto out_free_4;
kvm_chardev_ops.owner = module;
@@ -5905,10 +5905,9 @@ int kvm_init(void *opaque, unsigned vcpu_size, unsigned vcpu_align,
out_unreg:
kvm_async_pf_deinit();
-out_free_5:
+out_free_4:
for_each_possible_cpu(cpu)
free_cpumask_var(per_cpu(cpu_kick_mask, cpu));
-out_free_4:
kmem_cache_destroy(kvm_vcpu_cache);
out_free_3:
unregister_reboot_notifier(&kvm_reboot_notifier);