summaryrefslogtreecommitdiffstats
path: root/drivers/staging
Commit message (Collapse)AuthorAgeFilesLines
* staging: vc04_services: fix information leak in create_component()Dan Carpenter2024-03-251-0/+1
| | | | | | | | | | | | | The m.u.component_create.pid field is for debugging and in the mainline kernel it's not used anything. However, it still needs to be set to something to prevent disclosing uninitialized stack data. Set it to zero. Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.") Cc: stable <stable@kernel.org> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/2d972847-9ebd-481b-b6f9-af390f5aabd3@moroto.mountain Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: vc04_services: changen strncpy() to strscpy_pad()Arnd Bergmann2024-03-251-2/+2
| | | | | | | | | | | | | | | | | | | gcc-14 warns about this strncpy() that results in a non-terminated string for an overflow: In file included from include/linux/string.h:369, from drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:20: In function 'strncpy', inlined from 'create_component' at drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:940:2: include/linux/fortify-string.h:108:33: error: '__builtin_strncpy' specified bound 128 equals destination size [-Werror=stringop-truncation] Change it to strscpy_pad(), which produces a properly terminated and zero-padded string. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/20240313163712.224585-1-arnd@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Merge tag 'staging-6.9-rc1' of ↵Linus Torvalds2024-03-2171-4814/+535
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging Pull staging driver updates from Greg KH: "Here is the big set of Staging driver cleanups for 6.9-rc1. Nothing major in here, lots of small coding style cleanups for most drivers, and the removal of some obsolete hardare (the emxx_udc and some drivers/staging/board/ files). All of these have been in linux-next for a long time with no reported issues" * tag 'staging-6.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (122 commits) staging: greybus: Replaces directive __attribute__((packed)) by __packed as suggested by checkpatch staging: greybus: Replace __attribute__((packed)) by __packed in various instances Staging: rtl8192e: Rename function GetHalfNmodeSupportByAPsHandler() Staging: rtl8192e: Rename function rtllib_FlushRxTsPendingPkts() Staging: rtl8192e: Rename goto OnADDBARsp_Reject Staging: rtl8192e: Rename goto OnADDBAReq_Fail Staging: rtl8192e: Rename function rtllib_send_ADDBARsp() Staging: rtl8192e: Rename function rtllib_send_ADDBAReq() Staging: rtl8192e: Rename variable TxRxSelect Staging: rtl8192e: Fix 5 chckpatch alignment warnings in rtl819x_BAProc.c Staging: rtl8192e: Rename function MgntQuery_MgntFrameTxRate Staging: rtl8192e: Rename boolean variable bHalfWirelessN24GMode Staging: rtl8192e: Rename reference AllowAllDestAddrHandler Staging: rtl8192e: Rename varoable asSta Staging: rtl8192e: Rename varoable osCcxVerNum Staging: rtl8192e: Rename variable CcxAironetBuf Staging: rtl8192e: Rename variable osCcxAironetIE Staging: rtl8192e: Rename variable AironetIeOui Staging: rtl8192e: Rename variable asRsn Staging: rtl8192e: Rename variable CcxVerNumBuf ...
| * staging: greybus: Replaces directive __attribute__((packed)) by __packed as ↵Jonathan Bergh2024-03-071-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | suggested by checkpatch This patch makes the following changes: * Replaces '__attribute__((packed))' by '__packed' to remove warning as flagged by checkpatch Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> Link: https://lore.kernel.org/r/20240227160113.111264-2-bergh.jonathan@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: greybus: Replace __attribute__((packed)) by __packed in various ↵Jonathan Bergh2024-03-071-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | instances This patch makes the following changes: * Replaces '__attribute__((packed))' by '__packed' in various locations to remove checkpatch warning Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> Link: https://lore.kernel.org/r/20240227160113.111264-1-bergh.jonathan@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename function GetHalfNmodeSupportByAPsHandler()Tree Davies2024-03-055-8/+8
| | | | | | | | | | | | | | | | | | | | | | Rename function GetHalfNmodeSupportByAPsHandler to get_half_nmode_support_by_aps_handler to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240229024325.453374-9-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename function rtllib_FlushRxTsPendingPkts()Tree Davies2024-03-053-5/+5
| | | | | | | | | | | | | | | | | | | | | | Rename function rtllib_FlushRxTsPendingPkts to rtllib_flush_rx_ts_pending_pkts to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240229024325.453374-8-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename goto OnADDBARsp_RejectTree Davies2024-03-051-6/+6
| | | | | | | | | | | | | | | | | | | | Rename goto OnADDBARsp_Reject -> on_add_ba_rsp_reject to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240229024325.453374-7-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename goto OnADDBAReq_FailTree Davies2024-03-051-4/+4
| | | | | | | | | | | | | | | | | | | | Rename goto OnADDBAReq_Fail -> on_add_ba_req_fail to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240229024325.453374-6-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename function rtllib_send_ADDBARsp()Tree Davies2024-03-051-4/+4
| | | | | | | | | | | | | | | | | | | | Rename function rtllib_send_ADDBARsp to rtllib_send_add_ba_rsp to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240229024325.453374-5-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename function rtllib_send_ADDBAReq()Tree Davies2024-03-051-3/+3
| | | | | | | | | | | | | | | | | | | | Rename function rtllib_send_ADDBAReq to rtllib_send_add_ba_req to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240229024325.453374-4-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable TxRxSelectTree Davies2024-03-053-23/+23
| | | | | | | | | | | | | | | | | | | | Rename variable TxRxSelect to tx_rx_select to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240229024325.453374-3-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Fix 5 chckpatch alignment warnings in rtl819x_BAProc.cTree Davies2024-03-051-5/+5
| | | | | | | | | | | | | | | | | | | | Add tabs and spaces to fix checkpatch warning: 'Alignment should match open parenthesis' Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240229024325.453374-2-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename function MgntQuery_MgntFrameTxRateTree Davies2024-03-051-3/+3
| | | | | | | | | | | | | | | | | | | | Rename function MgntQuery_MgntFrameTxRate to mgnt_query_mgnt_frame_tx_rate to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-21-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename boolean variable bHalfWirelessN24GModeTree Davies2024-03-053-4/+4
| | | | | | | | | | | | | | | | | | | | Rename boolean variable bHalfWirelessN24GMode to half_wireless_n24g_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-20-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename reference AllowAllDestAddrHandlerTree Davies2024-03-053-5/+6
| | | | | | | | | | | | | | | | | | | | Rename variable AllowAllDestAddrHandler to allow_all_dest_addr_handler to fix checkpatch warning Avoid CamelCase, Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-19-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename varoable asStaTree Davies2024-03-051-3/+3
| | | | | | | | | | | | | | | | | | | | Rename variable asSta to addr as it references bssid addr, and fixes checkpatch warning Avoid CamelCase, Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-18-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename varoable osCcxVerNumTree Davies2024-03-051-6/+6
| | | | | | | | | | | | | | | | | | | | Rename variable osCcxVerNum to os_vcx_ver_num to fix checkpatch warning Avoid CamelCase, Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-17-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable CcxAironetBufTree Davies2024-03-051-4/+4
| | | | | | | | | | | | | | | | | | | | Rename variable CcxAironetBuf to ccx_aironet_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-16-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable osCcxAironetIETree Davies2024-03-051-8/+8
| | | | | | | | | | | | | | | | | | | | Rename variable osCcxAironetIE to os_ccx_aironet_ie to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-15-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable AironetIeOuiTree Davies2024-03-051-3/+3
| | | | | | | | | | | | | | | | | | | | Rename variable AironetIeOui to aironet_ie_oui to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-14-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable asRsnTree Davies2024-03-052-14/+14
| | | | | | | | | | | | | | | | | | | | Rename variable asRsn to rsn to fix checkpatch warning Avoid CamelCase, and adjust spacing to avoid alignment check. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-13-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable CcxVerNumBufTree Davies2024-03-051-4/+4
| | | | | | | | | | | | | | | | | | | | Rename variable CcxVerNumBuf to ccx_ver_num_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-12-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable BssCcxVerNumberTree Davies2024-03-053-7/+7
| | | | | | | | | | | | | | | | | | | | Rename variable BssCcxVerNumber to bss_ccx_ver_number to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-11-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable CcxRmCapBufTree Davies2024-03-051-3/+3
| | | | | | | | | | | | | | | | | | | | Rename variable CcxRmCapBuf to ccx_rm_cap_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-10-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable bCcxRmEnableTree Davies2024-03-053-7/+7
| | | | | | | | | | | | | | | | | | | | Rename variable bCcxRmEnable to ccx_rm_enable to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-9-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable bCkipSupportedTree Davies2024-03-053-7/+7
| | | | | | | | | | | | | | | | | | | | Rename variable bCkipSupported to ckip_supported to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-8-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable osCcxRmCapTree Davies2024-03-051-6/+6
| | | | | | | | | | | | | | | | | | | | Rename variable osCcxRmCap to os_ccx_rm_cap to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-7-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable Turbo_EnableTree Davies2024-03-053-5/+5
| | | | | | | | | | | | | | | | | | | | Rename variable Turbo_Enable to turbo_enable to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-6-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable PMKIDListTree Davies2024-03-052-4/+4
| | | | | | | | | | | | | | | | | | | | Rename variable PMKIDList to pmkid_list to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-5-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename function SecIsInPMKIDList()Tree Davies2024-03-051-2/+2
| | | | | | | | | | | | | | | | | | | | Rename function SecIsInPMKIDList to sec_is_in_pmkid_list to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-4-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename variable NumRecvDataInPeriodTree Davies2024-03-055-9/+9
| | | | | | | | | | | | | | | | | | | | Rename variable NumRecvDataInPeriod to num_recv_data_in_period to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-3-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8192e: Rename function rtllib_rx_ADDBAReq()Tree Davies2024-03-053-3/+3
| | | | | | | | | | | | | | | | | | | | Rename function rtllib_rx_ADDBAReq to rtllib_rx_add_ba_req to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-2-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: vme_user: Fix misaligned closing comment */Jonathan Bergh2024-03-051-4/+2
| | | | | | | | | | | | | | | | | | | | This patch makes the following change: * Ensures the trailing */ for comments is on the same line as the opening /* Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> Link: https://lore.kernel.org/r/20240303100547.153636-1-bergh.jonathan@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: fbtft: remove unused variable 'count'Colin Ian King2024-03-051-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The variable count is being initialized and incremented but it is never actually referenced in any other way. The variable is redundant and can be removed. Cleans up clang scan build warning: drivers/staging/fbtft/fbtft-core.c:330:6: warning: variable 'count' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20240229120114.219085-1-colin.i.king@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: pi433: Move FIFO_THRESHOLD define to source fileShahar Avidar2024-03-052-1/+1
| | | | | | | | | | | | | | | | | | FIFO_THRESHOLD is only being used in pi433_if.c source files. Signed-off-by: Shahar Avidar <ikobh7@gmail.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20240227221204.534131-6-ikobh7@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: pi433: Remove the unused FREQUENCY defineShahar Avidar2024-03-051-2/+0
| | | | | | | | | | | | | | | | | | FREQUENCY is not being used, delete its comment. Signed-off-by: Shahar Avidar <ikobh7@gmail.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20240227221204.534131-5-ikobh7@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: pi433: Redefine F_OSC using units.h macroShahar Avidar2024-03-051-1/+2
| | | | | | | | | | | | | | | | | | | | Use HZ_PER_MHZ for a more robust definition. Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Shahar Avidar <ikobh7@gmail.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20240227221204.534131-4-ikobh7@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: pi433: Remove a duplicated F_OSC defineShahar Avidar2024-03-051-1/+0
| | | | | | | | | | | | | | | | | | F_OSC is already defined & only used by rf69.c source file. Signed-off-by: Shahar Avidar <ikobh7@gmail.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20240227221204.534131-3-ikobh7@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: pi433: Remove a duplicated FIFO_SIZE defineShahar Avidar2024-03-051-1/+0
| | | | | | | | | | | | | | | | | | | | FIFO_SIZE is being used in both rf69.c & pi433_if.c source files. It is also already defined in rf69.h header file. Signed-off-by: Shahar Avidar <ikobh7@gmail.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20240227221204.534131-2-ikobh7@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8192e: rename enum members to upper caseMichael Straube2024-03-052-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enum members are usually named all upper case. Rename the members of the enum fsync_state to improve readability and follow the common kernel coding style. Default_Fsync -> DEFAULT_FSYNC HW_Fsync -> HW_FSYNC SW_Fsync -> SW_FSYNC Signed-off-by: Michael Straube <straube.linux@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240222112723.18428-4-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8192e: remove empty cases from switch statementsMichael Straube2024-03-051-3/+0
| | | | | | | | | | | | | | | | | | | | Rmove empty cases from switch statements to improve readability. All of these empty cases are covered by a default case already. Signed-off-by: Michael Straube <straube.linux@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240222112723.18428-3-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8192e: rename rateIndex to rate_indexMichael Straube2024-03-051-32/+32
| | | | | | | | | | | | | | | | | | | | | | | | Rename the variable rateIndex in the function _rtl92e_update_received_rate_histogram_stats() to avoid camel case. rateIndex -> rate_index Signed-off-by: Michael Straube <straube.linux@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240222112723.18428-2-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8723bs: remove redundant variable hoffsetColin Ian King2024-03-051-12/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Variable hoffset in functions hal_EfuseGetCurrentSize_WiFi and hal_EfuseGetCurrentSize_BT is being assigned a value but it not being read for any useful reason at all. The variable is redundant and can be removed. Cleans up clang scan build warnings for lines 957 and 1050: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:957:5: warning: variable 'hoffset' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20240304161045.769912-1-colin.i.king@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8723bs: Remove dead code from _rtw_free_network()Meir Elisha2024-03-051-2/+0
| | | | | | | | | | | | | | | | Clean dead code from is_same_network() and _rtw_free_network(). Signed-off-by: Meir Elisha <meir6264@gmail.com> Link: https://lore.kernel.org/r/20240229121445.22257-1-meir6264@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: rtl8723bs: Remove unnecessary braces in rtw_update_ht_capMeir Elisha2024-03-051-4/+3
| | | | | | | | | | | | | | | | Remove braces from single statement blocks to improve coding style. Signed-off-by: Meir Elisha <meir6264@gmail.com> Link: https://lore.kernel.org/r/20240220122802.12561-1-meir6264@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * Staging: octeon: Match parenthesis alignmentDorine Tipo2024-03-051-1/+1
| | | | | | | | | | | | | | | | Align the function parameters to silence a checkpatch warning. Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com> Link: https://lore.kernel.org/r/20240305092310.3594-1-dorine.a.tipo@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8192e: Remove unused variables ntotalfrag and Seq_NumPhilipp Hortmann2024-03-052-10/+0
| | | | | | | | | | | | | | | | | | Remove unused variables ntotalfrag and Seq_Num as they are set and never evaluated. Remove resulting local variables seq, sc and hdr as well. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/4a3f2d217631076ee9994b46f8672eceaea8568c.1708461563.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8192e: Remove unused variables bShortPreamble and fragoffsetPhilipp Hortmann2024-03-052-4/+0
| | | | | | | | | | | | | | | | | | Remove unused variables bShortPreamble and fragoffset as they are set and never evaluated. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/17c516c195acc458366ab182e0fd1200b7e2b1da.1708461563.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: rtl8192e: Remove unused variables nic_type and RxPowerPhilipp Hortmann2024-03-053-5/+0
| | | | | | | | | | | | | | | | | | Remove unused variables nic_type and RxPower as they are set and never evaluated. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/96f8c089aefe6648dad0c68663211b375f016517.1708461563.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>