diff options
| author | Trond Myklebust <trond.myklebust@hammerspace.com> | 2019-08-03 10:28:18 -0400 |
|---|---|---|
| committer | Trond Myklebust <trond.myklebust@hammerspace.com> | 2019-08-04 22:35:41 -0400 |
| commit | 09a54f0ebfe263bc27c90bbd80187b9a93283887 (patch) | |
| tree | de7acc0ecef8265c0320a6f6ef0b04cf5e317103 | |
| parent | c77e22834ae9a11891cb613bd9a551be1b94f2bc (diff) | |
| download | linux-09a54f0ebfe263bc27c90bbd80187b9a93283887.tar.gz linux-09a54f0ebfe263bc27c90bbd80187b9a93283887.tar.bz2 linux-09a54f0ebfe263bc27c90bbd80187b9a93283887.zip | |
NFSv4: Fix an Oops in nfs4_do_setattr
If the user specifies an open mode of 3, then we don't have a NFSv4 state
attached to the context, and so we Oops when we try to dereference it.
Reported-by: Olga Kornievskaia <aglo@umich.edu>
Fixes: 29b59f9416937 ("NFSv4: change nfs4_do_setattr to take...")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: stable@vger.kernel.org # v4.10: 991eedb1371dc: NFSv4: Only pass the...
Cc: stable@vger.kernel.org # v4.10+
| -rw-r--r-- | fs/nfs/nfs4proc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 3e0b93f2b61a..12b2b65ad8a8 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3214,7 +3214,7 @@ static int _nfs4_do_setattr(struct inode *inode, if (nfs4_copy_delegation_stateid(inode, FMODE_WRITE, &arg->stateid, &delegation_cred)) { /* Use that stateid */ - } else if (ctx != NULL) { + } else if (ctx != NULL && ctx->state) { struct nfs_lock_context *l_ctx; if (!nfs4_valid_open_stateid(ctx->state)) return -EBADF; |