diff options
| author | Guoqing Jiang <jgq516@gmail.com> | 2019-07-24 11:09:21 +0200 |
|---|---|---|
| committer | Song Liu <songliubraving@fb.com> | 2019-08-07 10:25:02 -0700 |
| commit | 0d8ed0e9bf9643f27f4816dca61081784dedb38d (patch) | |
| tree | 21a6c537153637403299b285e78dc917e3948002 | |
| parent | 062f5b2ae12a153644c765e7ba3b0f825427be1d (diff) | |
| download | linux-0d8ed0e9bf9643f27f4816dca61081784dedb38d.tar.gz linux-0d8ed0e9bf9643f27f4816dca61081784dedb38d.tar.bz2 linux-0d8ed0e9bf9643f27f4816dca61081784dedb38d.zip | |
md: don't call spare_active in md_reap_sync_thread if all member devices can't work
When add one disk to array, the md_reap_sync_thread is responsible
to activate the spare and set In_sync flag for the new member in
spare_active().
But if raid1 has one member disk A, and disk B is added to the array.
Then we offline A before all the datas are synchronized from A to B,
obviously B doesn't have the latest data as A, but B is still marked
with In_sync flag.
So let's not call spare_active under the condition, otherwise B is
still showed with 'U' state which is not correct.
Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
| -rw-r--r-- | drivers/md/md.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index 1cdaa6ff9bd7..daa885ee4d60 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -9075,7 +9075,8 @@ void md_reap_sync_thread(struct mddev *mddev) /* resync has finished, collect result */ md_unregister_thread(&mddev->sync_thread); if (!test_bit(MD_RECOVERY_INTR, &mddev->recovery) && - !test_bit(MD_RECOVERY_REQUESTED, &mddev->recovery)) { + !test_bit(MD_RECOVERY_REQUESTED, &mddev->recovery) && + mddev->degraded != mddev->raid_disks) { /* success...*/ /* activate any spares */ if (mddev->pers->spare_active(mddev)) { |