diff options
| author | ChiYuan Huang <cy_huang@richtek.com> | 2022-12-14 09:37:11 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-12-14 13:36:45 +0000 |
| commit | 0debed5b117d11e33cba52870c4dcb64f5911891 (patch) | |
| tree | ee8a41d4f05772e59fb6c5fa811417b0f832e361 | |
| parent | 8f3cbcd6b440032ebc7f7d48a1689dcc70a4eb98 (diff) | |
| download | linux-0debed5b117d11e33cba52870c4dcb64f5911891.tar.gz linux-0debed5b117d11e33cba52870c4dcb64f5911891.tar.bz2 linux-0debed5b117d11e33cba52870c4dcb64f5911891.zip | |
regulator: core: Fix resolve supply lookup issue
From Marek's log, the previous change modify the parent of rdev.
https://lore.kernel.org/all/58b92e75-f373-dae7-7031-8abd465bb874@samsung.com/
In 'regulator_resolve_supply', it uses the parent DT node of rdev as the
DT-lookup starting node. But the parent DT node may not exist. This will
cause the NULL supply issue.
This patch modify the parent of rdev back to the device that provides
from 'regulator_config' in 'regulator_register'.
Fixes: 8f3cbcd6b440 ("regulator: core: Use different devices for resource allocation and DT lookup")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
Link: https://lore.kernel.org/r/1670981831-12583-1-git-send-email-u0084500@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/regulator/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index c84e8d78dc7e..35a7785c53f6 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -5539,7 +5539,7 @@ regulator_register(struct device *dev, /* register with sysfs */ rdev->dev.class = ®ulator_class; - rdev->dev.parent = dev; + rdev->dev.parent = config->dev; dev_set_name(&rdev->dev, "regulator.%lu", (unsigned long) atomic_inc_return(®ulator_no)); dev_set_drvdata(&rdev->dev, rdev); |