diff options
| author | Jiawen Wu <jiawenwu@trustnetic.com> | 2024-03-01 17:29:56 +0800 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2024-03-05 11:13:04 +0100 |
| commit | 0e71862a20d58b6e8d4c39de1d72c8919c4dccd1 (patch) | |
| tree | 898a971cdc83c36df9e56c878c48c760dd36b04a | |
| parent | b4a2496c17ed645f8d51061047c9c249b58c74ba (diff) | |
| download | linux-0e71862a20d58b6e8d4c39de1d72c8919c4dccd1.tar.gz linux-0e71862a20d58b6e8d4c39de1d72c8919c4dccd1.tar.bz2 linux-0e71862a20d58b6e8d4c39de1d72c8919c4dccd1.zip | |
net: txgbe: fix to clear interrupt status after handling IRQ
GPIO EOI is not set to clear interrupt status after handling the
interrupt. It should be done in irq_chip->irq_ack, but this function
is not called in handle_nested_irq(). So executing function
txgbe_gpio_irq_ack() manually in txgbe_gpio_irq_handler().
Fixes: aefd013624a1 ("net: txgbe: use irq_domain for interrupt controller")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Link: https://lore.kernel.org/r/20240301092956.18544-2-jiawenwu@trustnetic.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
| -rw-r--r-- | drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c index c112f79b026e..93295916b1d2 100644 --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c @@ -475,8 +475,10 @@ irqreturn_t txgbe_gpio_irq_handler(int irq, void *data) gc = txgbe->gpio; for_each_set_bit(hwirq, &gpioirq, gc->ngpio) { int gpio = irq_find_mapping(gc->irq.domain, hwirq); + struct irq_data *d = irq_get_irq_data(gpio); u32 irq_type = irq_get_trigger_type(gpio); + txgbe_gpio_irq_ack(d); handle_nested_irq(gpio); if ((irq_type & IRQ_TYPE_SENSE_MASK) == IRQ_TYPE_EDGE_BOTH) { |