summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCong Ding <dinggnu@gmail.com>2013-02-01 22:33:21 -0500
committerTheodore Ts'o <tytso@mit.edu>2013-02-01 22:33:21 -0500
commit0e79537d30f9dd66ccef70f1c7571594088e30be (patch)
tree584573b9c36dde6f07756a6d57cb8c7065c959fd
parentf1167009711032b0d747ec89a632a626c901a1ad (diff)
downloadlinux-0e79537d30f9dd66ccef70f1c7571594088e30be.tar.gz
linux-0e79537d30f9dd66ccef70f1c7571594088e30be.tar.bz2
linux-0e79537d30f9dd66ccef70f1c7571594088e30be.zip
ext4: reduce one "if" comparison in ext4_dirhash()
It is unnecessary to check i<4 after the loop; just do it before the break. Signed-off-by: Cong Ding <dinggnu@gmail.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
-rw-r--r--fs/ext4/hash.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/ext4/hash.c b/fs/ext4/hash.c
index fa8e4911d354..3d586f02883e 100644
--- a/fs/ext4/hash.c
+++ b/fs/ext4/hash.c
@@ -155,11 +155,11 @@ int ext4fs_dirhash(const char *name, int len, struct dx_hash_info *hinfo)
/* Check to see if the seed is all zero's */
if (hinfo->seed) {
for (i = 0; i < 4; i++) {
- if (hinfo->seed[i])
+ if (hinfo->seed[i]) {
+ memcpy(buf, hinfo->seed, sizeof(buf));
break;
+ }
}
- if (i < 4)
- memcpy(buf, hinfo->seed, sizeof(buf));
}
switch (hinfo->hash_version) {