diff options
| author | Nicolas Frattaroli <frattaroli.nicolas@gmail.com> | 2021-10-15 23:07:29 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-10-18 13:56:44 +0100 |
| commit | 0ea15e98cfbe56147e227360282ccd311e824b61 (patch) | |
| tree | a0baa16f9ba10307b3296cc9fb95dfe52358bfd4 | |
| parent | bc387887ae22d6ed6439e83968b5be3443a8e57d (diff) | |
| download | linux-0ea15e98cfbe56147e227360282ccd311e824b61.tar.gz linux-0ea15e98cfbe56147e227360282ccd311e824b61.tar.bz2 linux-0ea15e98cfbe56147e227360282ccd311e824b61.zip | |
ASoC: rockchip: i2s-tdm: Fix refcount test
During development of V5 of the i2s-tdm patch series, I replaced
the atomic refcount with a regular integer, as it was only ever
accessed within a spinlock.
Foolishly, I got the semantics of atomic_dec_and_test wrong, which
resulted in a test for 0 actually becoming a test for >0.
The result was that setting the audio frequency broke; switching
from 44100 Hz audio playback to 96000 Hz audio playback would
garble the sound most unpleasantly.
Fix this by checking for --refcount == 0, which is what it should
have been all along.
Fixes: 081068fd6414 ("ASoC: rockchip: add support for i2s-tdm controller")
Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Link: https://lore.kernel.org/r/20211015210730.308946-1-frattaroli.nicolas@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/rockchip/rockchip_i2s_tdm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c index 98424da313d5..e8dee1f95d85 100644 --- a/sound/soc/rockchip/rockchip_i2s_tdm.c +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c @@ -357,7 +357,7 @@ static void rockchip_snd_txrxctrl(struct snd_pcm_substream *substream, else rockchip_disable_rde(i2s_tdm->regmap); - if (--i2s_tdm->refcount) { + if (--i2s_tdm->refcount == 0) { rockchip_snd_xfer_clear(i2s_tdm, I2S_CLR_TXC | I2S_CLR_RXC); } |