summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYang Li <abaci-bugfix@linux.alibaba.com>2021-02-24 12:02:55 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2021-02-24 13:38:28 -0800
commit191a7221b70d7fa7005404f508e1802f6556ba78 (patch)
tree690f41ad4336786ec8c3ddbf7995e8a93e35dfcc
parent6986c3e2b19505e9b2112fc2e548e9f99fa3021f (diff)
downloadlinux-191a7221b70d7fa7005404f508e1802f6556ba78.tar.gz
linux-191a7221b70d7fa7005404f508e1802f6556ba78.tar.bz2
linux-191a7221b70d7fa7005404f508e1802f6556ba78.zip
mm/swap_slots.c: remove redundant NULL check
Fix below warnings reported by coccicheck: mm/swap_slots.c:197:3-9: WARNING: NULL check before some freeing functions is not needed. Link: https://lkml.kernel.org/r/1611214229-11225-1-git-send-email-abaci-bugfix@linux.alibaba.com Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com> Reported-by: Abaci Robot <abaci@linux.alibaba.com> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Reviewed-by: David Hildenbrand <david@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--mm/swap_slots.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/mm/swap_slots.c b/mm/swap_slots.c
index 0357fbe70645..be9de6d5b516 100644
--- a/mm/swap_slots.c
+++ b/mm/swap_slots.c
@@ -193,8 +193,7 @@ static void drain_slots_cache_cpu(unsigned int cpu, unsigned int type,
cache->slots_ret = NULL;
}
spin_unlock_irq(&cache->free_lock);
- if (slots)
- kvfree(slots);
+ kvfree(slots);
}
}