diff options
| author | Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com> | 2020-03-16 22:43:52 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-16 17:14:02 -0700 |
| commit | 1963507e6233ceda2afeb4b9e8e1f17d59855959 (patch) | |
| tree | 33003a57b7d5051205b000cc03970678a3b1b8c7 | |
| parent | 10ee4b87f5f94c8e6dce4be95f5e56c445d45dbf (diff) | |
| download | linux-1963507e6233ceda2afeb4b9e8e1f17d59855959.tar.gz linux-1963507e6233ceda2afeb4b9e8e1f17d59855959.tar.bz2 linux-1963507e6233ceda2afeb4b9e8e1f17d59855959.zip | |
net: kcm: kcmproc.c: Fix RCU list suspicious usage warning
This path fixes the suspicious RCU usage warning reported by
kernel test robot.
net/kcm/kcmproc.c:#RCU-list_traversed_in_non-reader_section
There is no need to use list_for_each_entry_rcu() in
kcm_stats_seq_show() as the list is always traversed under
knet->mutex held.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/kcm/kcmproc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/kcm/kcmproc.c b/net/kcm/kcmproc.c index 370da2f80e3c..25c1007f1098 100644 --- a/net/kcm/kcmproc.c +++ b/net/kcm/kcmproc.c @@ -261,7 +261,7 @@ static int kcm_stats_seq_show(struct seq_file *seq, void *v) aggregate_strp_stats(&knet->aggregate_strp_stats, &strp_stats); - list_for_each_entry_rcu(mux, &knet->mux_list, kcm_mux_list) { + list_for_each_entry(mux, &knet->mux_list, kcm_mux_list) { spin_lock_bh(&mux->lock); aggregate_mux_stats(&mux->stats, &mux_stats); aggregate_psock_stats(&mux->aggregate_psock_stats, |