diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2021-10-04 12:14:44 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-10-05 13:15:35 +0100 |
| commit | 1bb96a07f9a8f2fe9725f6689605e32b75d20508 (patch) | |
| tree | 608557fb2b4fab4764b39f17049f3444843dbaab | |
| parent | ded6e16b37e4c8c86cda98604ecd78818d6ca36a (diff) | |
| download | linux-1bb96a07f9a8f2fe9725f6689605e32b75d20508.tar.gz linux-1bb96a07f9a8f2fe9725f6689605e32b75d20508.tar.bz2 linux-1bb96a07f9a8f2fe9725f6689605e32b75d20508.zip | |
mlx4: replace mlx4_u64_to_mac() with u64_to_ether_addr()
mlx4_u64_to_mac() predates the common helper but doesn't
make the argument constant.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 | ||||
| -rw-r--r-- | include/linux/mlx4/driver.h | 10 |
2 files changed, 1 insertions, 11 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c index 9fadedfca41c..94ead263081f 100644 --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c @@ -3195,7 +3195,7 @@ int mlx4_set_vf_spoofchk(struct mlx4_dev *dev, int port, int vf, bool setting) port = mlx4_slaves_closest_port(dev, slave, port); s_info = &priv->mfunc.master.vf_admin[slave].vport[port]; - mlx4_u64_to_mac(mac, s_info->mac); + u64_to_ether_addr(s_info->mac, mac); if (setting && !is_valid_ether_addr(mac)) { mlx4_info(dev, "Illegal MAC with spoofchk\n"); return -EPERM; diff --git a/include/linux/mlx4/driver.h b/include/linux/mlx4/driver.h index b26b71f62fb4..1834c8fad12e 100644 --- a/include/linux/mlx4/driver.h +++ b/include/linux/mlx4/driver.h @@ -92,14 +92,4 @@ void *mlx4_get_protocol_dev(struct mlx4_dev *dev, enum mlx4_protocol proto, int struct devlink_port *mlx4_get_devlink_port(struct mlx4_dev *dev, int port); -static inline void mlx4_u64_to_mac(u8 *addr, u64 mac) -{ - int i; - - for (i = ETH_ALEN; i > 0; i--) { - addr[i - 1] = mac & 0xFF; - mac >>= 8; - } -} - #endif /* MLX4_DRIVER_H */ |