diff options
| author | Liang He <windhl@126.com> | 2022-06-28 22:31:55 +0800 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2022-08-19 14:35:43 -0700 |
| commit | 1d6aa08c54cd0e005210ab8e3b1e92ede70f8a4f (patch) | |
| tree | 236dc4b811d41d6d9e763617ec7b7cd124515952 | |
| parent | 429973306f860470cbbb8402c8c53143b450faba (diff) | |
| download | linux-1d6aa08c54cd0e005210ab8e3b1e92ede70f8a4f.tar.gz linux-1d6aa08c54cd0e005210ab8e3b1e92ede70f8a4f.tar.bz2 linux-1d6aa08c54cd0e005210ab8e3b1e92ede70f8a4f.zip | |
clk: oxnas: Hold reference returned by of_get_parent()
In oxnas_stdclk_probe(), we need to hold the reference returned by
of_get_parent() and use it to call of_node_put() for refcount
balance.
Fixes: 0bbd72b4c64f ("clk: Add Oxford Semiconductor OXNAS Standard Clocks")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220628143155.170550-1-windhl@126.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
| -rw-r--r-- | drivers/clk/clk-oxnas.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/clk/clk-oxnas.c b/drivers/clk/clk-oxnas.c index cda5e258355b..584e293156ad 100644 --- a/drivers/clk/clk-oxnas.c +++ b/drivers/clk/clk-oxnas.c @@ -207,7 +207,7 @@ static const struct of_device_id oxnas_stdclk_dt_ids[] = { static int oxnas_stdclk_probe(struct platform_device *pdev) { - struct device_node *np = pdev->dev.of_node; + struct device_node *np = pdev->dev.of_node, *parent_np; const struct oxnas_stdclk_data *data; struct regmap *regmap; int ret; @@ -215,7 +215,9 @@ static int oxnas_stdclk_probe(struct platform_device *pdev) data = of_device_get_match_data(&pdev->dev); - regmap = syscon_node_to_regmap(of_get_parent(np)); + parent_np = of_get_parent(np); + regmap = syscon_node_to_regmap(parent_np); + of_node_put(parent_np); if (IS_ERR(regmap)) { dev_err(&pdev->dev, "failed to have parent regmap\n"); return PTR_ERR(regmap); |